Re: [PATCH 01/43] hpsa: add masked physical devices into h->dev[] array

Christoph Hellwig
2015-03-05T13:34:59Z

On Thu, Feb 26, 2015 at 03:17:38PM +0000, brace wrote:
> Thanks, I corrected the code. Also, I asked Webb about setting up the queue
> Depth in slave_alloc. His reply was " We needed to get tagging set up during allocation so that we could use it in the lead-up to configuration, which is why it was done in hpsa_slave_alloc(); and, given that the code there was then already messing about with queue depth, it made sense to also deal with the rest of it there."
>
> But given your next comment, perhaps I need to clean this up more?

I think so. In older kernel we indeed had horrible APIs that mixed
setting up tagging with the queue depth, but this has all been sorted
out, so setting the queue depth in slave_alloc should not be nessecary
now.