RE: [PATCH 02/43] hpsa: clean up host, channel, target, lun prints

brace
2015-02-26T14:50:56Z

done

> -----Original Message-----
> From: Christoph Hellwig [mailto:hch@infradead.org]
> Sent: Monday, February 23, 2015 2:16 PM
> To: Don Brace
> Cc: Scott Teel; Kevin Barnett; james.bottomley@parallels.com;
> hch@infradead.org; Justin Lindley; brace; linux-scsi@vger.kernel.org
> Subject: Re: [PATCH 02/43] hpsa: clean up host, channel, target, lun prints
>
> > + dev_info(&h->pdev->dev,
> > + "%6s scsi %d:%d:%d:%d: %s %.8s %.16s RAID-%s
> SSDSmartPathCap%c En%c Exp=%d\n",
>
> So you still have an action before the identifier. Can't you just add
> a hpsa_dev_printk macro similar to sdev_printk that encapsulates the
> format, and also makes sure it's always the prefix for the log message?