From: Tina Ruchandani <ruchandani.tina@gmail.com>
To: linux-scsi@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>,
"James E.J. Bottomley" <JBottomley@parallels.com>
Subject: [PATCH v2] scsi: pmcraid: Remove usage of struct timeval
Date: Wed, 25 Feb 2015 07:49:21 +0530 [thread overview]
Message-ID: <20150225021921.GA2890@tinar> (raw)
struct timeval will have its tv_sec field overflow on 32-bit systems
in year 2038 and beyond. This patch removes the usage of struct timeval
and instead uses 64-bit ktime_t to get the current milliseconds
to populate pmcraid_timestamp_data.
Signed-off-by: Tina Ruchandani <ruchandani.tina@gmail.com>
--
Changes in v2:
- Change subject line to indicate that change is local to pmcraid driver
and doesn't cover all of scsi subsystem.
- Use u64 instead of __l64 for timestamp, as it being set to a cpu-endian
value.
---
drivers/scsi/pmcraid.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
index 8c27b6a..60ce3c9 100644
--- a/drivers/scsi/pmcraid.c
+++ b/drivers/scsi/pmcraid.c
@@ -25,6 +25,7 @@
#include <linux/fs.h>
#include <linux/init.h>
#include <linux/types.h>
+#include <linux/ktime.h>
#include <linux/errno.h>
#include <linux/kernel.h>
#include <linux/ioport.h>
@@ -5569,11 +5570,9 @@ static void pmcraid_set_timestamp(struct pmcraid_cmd *cmd)
__be32 time_stamp_len = cpu_to_be32(PMCRAID_TIMESTAMP_LEN);
struct pmcraid_ioadl_desc *ioadl = ioarcb->add_data.u.ioadl;
- struct timeval tv;
- __le64 timestamp;
+ u64 timestamp;
- do_gettimeofday(&tv);
- timestamp = tv.tv_sec * 1000;
+ timestamp = ktime_to_ms(ktime_get_real());
pinstance->timestamp_data->timestamp[0] = (__u8)(timestamp);
pinstance->timestamp_data->timestamp[1] = (__u8)((timestamp) >> 8);
--
2.2.0.rc0.207.ga3a616c
next reply other threads:[~2015-02-25 2:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 2:19 Tina Ruchandani [this message]
2015-02-25 8:41 ` [PATCH v2] scsi: pmcraid: Remove usage of struct timeval Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150225021921.GA2890@tinar \
--to=ruchandani.tina@gmail.com \
--cc=JBottomley@parallels.com \
--cc=arnd@arndb.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox