* [patch] [SCSI] bfa: fix bfa_cb_sfp_state_query()
@ 2015-02-25 13:12 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2015-02-25 13:12 UTC (permalink / raw)
To: Anil Gurumurthy, Krishna Gudipati
Cc: Sudarsana Kalluru, James E.J. Bottomley, linux-scsi,
kernel-janitors
There are several missing curly braces so this function doesn't work as
intended.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/scsi/bfa/bfa_ioc.c b/drivers/scsi/bfa/bfa_ioc.c
index 315d6d6..59c3492 100644
--- a/drivers/scsi/bfa/bfa_ioc.c
+++ b/drivers/scsi/bfa/bfa_ioc.c
@@ -3662,7 +3662,7 @@ bfa_cb_sfp_state_query(struct bfa_sfp_s *sfp)
bfa_trc(sfp, sfp->portspeed);
if (sfp->media) {
bfa_sfp_media_get(sfp);
- if (sfp->state_query_cbfn)
+ if (sfp->state_query_cbfn) {
sfp->state_query_cbfn(sfp->state_query_cbarg,
sfp->status);
sfp->media = NULL;
@@ -3670,14 +3670,16 @@ bfa_cb_sfp_state_query(struct bfa_sfp_s *sfp)
if (sfp->portspeed) {
sfp->status = bfa_sfp_speed_valid(sfp, sfp->portspeed);
- if (sfp->state_query_cbfn)
+ if (sfp->state_query_cbfn) {
sfp->state_query_cbfn(sfp->state_query_cbarg,
sfp->status);
sfp->portspeed = BFA_PORT_SPEED_UNKNOWN;
+ }
}
sfp->state_query_lock = 0;
sfp->state_query_cbfn = NULL;
+ }
}
/*
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-02-25 13:13 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-25 13:12 [patch] [SCSI] bfa: fix bfa_cb_sfp_state_query() Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox