From: Christoph Hellwig <hch@infradead.org>
To: Don Brace <don.brace@pmcs.com>
Cc: scott.teel@pmcs.com, Kevin.Barnett@pmcs.com,
james.bottomley@parallels.com, hch@infradead.org,
Justin.Lindley@pmcs.com, brace@pmcs.com,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH v2 01/41] hpsa: add masked physical devices into h->dev[] array
Date: Sun, 8 Mar 2015 08:37:08 -0700 [thread overview]
Message-ID: <20150308153708.GA17534@infradead.org> (raw)
In-Reply-To: <20150306234552.29973.81396.stgit@brunhilda>
> + if (!shost_use_blk_mq(sdev->host))
> + sdev->tagged_supported = 1;
no need to do this conditionally on using blk-mq. In fact I'm pretty
sure yo udon't need this at all given that hpsa doesn't make use of
the SCMD_TAGGED flag.
next prev parent reply other threads:[~2015-03-08 15:37 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-06 23:45 [PATCH v2 00/41] hpsa updates Don Brace
2015-03-06 23:45 ` [PATCH v2 01/41] hpsa: add masked physical devices into h->dev[] array Don Brace
2015-03-08 15:37 ` Christoph Hellwig [this message]
2015-03-06 23:45 ` [PATCH v2 02/41] hpsa: clean up host, channel, target, lun prints Don Brace
2015-03-08 15:38 ` Christoph Hellwig
2015-03-06 23:46 ` [PATCH v2 03/41] hpsa: rework controller command submission Don Brace
2015-03-06 23:46 ` [PATCH v2 04/41] hpsa: clean up aborts Don Brace
2015-03-06 23:46 ` [PATCH v2 05/41] hpsa: decrement h->commands_outstanding in fail_all_outstanding_cmds Don Brace
2015-03-06 23:46 ` [PATCH v2 06/41] hpsa: hpsa decode sense data for io and tmf Don Brace
2015-03-08 15:40 ` Christoph Hellwig
2015-03-06 23:46 ` [PATCH v2 07/41] hpsa: allow lockup detected to be viewed via sysfs Don Brace
2015-03-06 23:46 ` [PATCH v2 08/41] hpsa: make function names consistent Don Brace
2015-03-06 23:46 ` [PATCH v2 09/41] hpsa: factor out hpsa_init_cmd function Don Brace
2015-03-06 23:46 ` [PATCH v2 10/41] hpsa: do not ignore return value of hpsa_register_scsi Don Brace
2015-03-06 23:46 ` [PATCH v2 11/41] hpsa: try resubmitting down raid path on task set full Don Brace
2015-03-06 23:46 ` [PATCH v2 12/41] hpsa: factor out hpsa_ioaccel_submit function Don Brace
2015-03-06 23:46 ` [PATCH v2 13/41] hpsa: print accurate SSD Smart Path Enabled status Don Brace
2015-03-06 23:47 ` [PATCH v2 14/41] hpsa: use ioaccel2 path to submit IOs to physical drives in HBA mode Don Brace
2015-03-06 23:47 ` [PATCH v2 15/41] hpsa: Get queue depth from identify physical bmic for physical disks Don Brace
2015-03-06 23:47 ` [PATCH v2 16/41] hpsa: break hpsa_free_irqs_and_disable_msix into two functions Don Brace
2015-03-08 15:42 ` Christoph Hellwig
2015-03-06 23:47 ` [PATCH v2 17/41] hpsa: clean up error handling Don Brace
2015-03-06 23:47 ` [PATCH v2 18/41] hpsa: refactor freeing of resources into more logical functions Don Brace
2015-03-06 23:47 ` [PATCH v2 19/41] hpsa: add ioaccel sg chaining for the ioaccel2 path Don Brace
2015-03-06 23:47 ` [PATCH v2 20/41] hpsa: add more ioaccel2 error handling, including underrun statuses Don Brace
2015-03-06 23:47 ` [PATCH v2 21/41] hpsa: do not check cmd_alloc return value - it cannnot return NULL Don Brace
2015-03-06 23:47 ` [PATCH v2 22/41] hpsa: correct return values from driver functions Don Brace
2015-03-06 23:47 ` [PATCH v2 23/41] hpsa: clean up driver init Don Brace
2015-03-06 23:47 ` [PATCH v2 24/41] hpsa: clean up some error reporting output in abort handler Don Brace
2015-03-06 23:47 ` [PATCH v2 25/41] hpsa: do not print ioaccel2 warning messages about unusual completions Don Brace
2015-03-06 23:48 ` [PATCH v2 26/41] hpsa: add support sending aborts to physical devices via the ioaccel2 path Don Brace
2015-03-06 23:48 ` [PATCH v2 27/41] hpsa: use helper routines for finishing commands Don Brace
2015-03-06 23:48 ` [PATCH v2 28/41] hpsa: don't return abort request until target is complete Don Brace
2015-03-06 23:48 ` [PATCH v2 29/41] hpsa: refactor and rework support for sending TEST_UNIT_READY Don Brace
2015-03-06 23:48 ` [PATCH v2 30/41] hpsa: performance tweak for hpsa_scatter_gather() Don Brace
2015-03-06 23:48 ` [PATCH v2 31/41] hpsa: call pci_release_regions after pci_disable_device Don Brace
2015-03-06 23:48 ` [PATCH v2 32/41] hpsa: skip free_irq calls if irqs are not allocated Don Brace
2015-03-06 23:48 ` [PATCH v2 33/41] hpsa: cleanup for init_one step 2 in kdump Don Brace
2015-03-06 23:48 ` [PATCH v2 34/41] hpsa: fix try_soft_reset error handling Don Brace
2015-03-06 23:48 ` [PATCH v2 35/41] hpsa: create workqueue after the driver is ready for use Don Brace
2015-03-06 23:48 ` [PATCH v2 36/41] hpsa: add interrupt number to /proc/interrupts interrupt name Don Brace
2015-03-06 23:49 ` [PATCH v2 37/41] hpsa: use block layer tag for command allocation Don Brace
2015-03-06 23:49 ` [PATCH v2 38/41] hpsa: use scsi host_no as hpsa controller number Don Brace
2015-03-06 23:49 ` [PATCH v2 39/41] hpsa: propagate the error code in hpsa_kdump_soft_reset Don Brace
2015-03-06 23:49 ` [PATCH v2 40/41] hpsa: cleanup reset Don Brace
2015-03-06 23:49 ` [PATCH v2 41/41] hpsa: change driver version Don Brace
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150308153708.GA17534@infradead.org \
--to=hch@infradead.org \
--cc=Justin.Lindley@pmcs.com \
--cc=Kevin.Barnett@pmcs.com \
--cc=brace@pmcs.com \
--cc=don.brace@pmcs.com \
--cc=james.bottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=scott.teel@pmcs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).