From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: James Bottomley <jbottomley@parallels.com>,
"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
Hannes Reinecke <hare@suse.de>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH for kernel 4.1] Split SCSI header files
Date: Sun, 8 Mar 2015 17:12:06 +0100 [thread overview]
Message-ID: <20150308161206.GA24616@lst.de> (raw)
In-Reply-To: <54F86F27.3000505@sandisk.com>
On Thu, Mar 05, 2015 at 03:58:47PM +0100, Bart Van Assche wrote:
> Thanks for the review. Whether scsi_lun.h is separate or not is not
> important to me. The only reason I had proposed to create a separate
> header file for struct scsi_lun is because some other header files only
> need the definition of that structure and not any other definition that
> is present in the proposed scsi_proto.h header file.
Given how small and simple scsi_proto.h is that doesn't seem worth it to me.
> Creating a library of functions that are shared by initiator and target
> makes sense to me. Not only the LUN translation functions but also
> functions like scsi_command_size() are useful for both SCSI initiator
> and SCSI target code. If anyone has a suggestion for a good name for
> such a library that would be welcome. Unfortunately there is already a
> source file with the name scsi_lib.c in the kernel tree so using the
> name scsi_lib.h might be confusing.
scsi_common might be a good name for both the module and the header file.
prev parent reply other threads:[~2015-03-08 16:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 8:40 [PATCH for kernel 4.1] Split SCSI header files Bart Van Assche
2015-02-27 20:17 ` Nicholas A. Bellinger
2015-03-05 14:26 ` Christoph Hellwig
2015-03-05 14:58 ` Bart Van Assche
2015-03-08 16:12 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150308161206.GA24616@lst.de \
--to=hch@lst.de \
--cc=bart.vanassche@sandisk.com \
--cc=hare@suse.de \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).