From: Sebastian Herbszt <herbszt@gmx.de>
To: james.smart@emulex.com
Cc: linux-scsi@vger.kernel.org, Sebastian Herbszt <herbszt@gmx.de>
Subject: Re: [PATCH 10/21] lpfc: Fix provide host name and OS name in RSNN-NN FC-GS command
Date: Sun, 5 Apr 2015 14:07:48 +0200 [thread overview]
Message-ID: <20150405140748.00007e42@localhost> (raw)
In-Reply-To: <1428095522.6933.38.camel@myfc17>
James Smart wrote:
> Fix provide host name and OS name in RSNN-NN FC-GS command
>
> Signed-off-by: Dick Kennedy <dick.kennedy@emulex.com>
> Signed-off-by: James Smart <james.smart@emulex.com>
> ---
> drivers/scsi/lpfc/lpfc_ct.c | 21 +++++++++++++++++++--
> 1 file changed, 19 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_ct.c b/drivers/scsi/lpfc/lpfc_ct.c
> index 61a32cd..c259eb0 100644
> --- a/drivers/scsi/lpfc/lpfc_ct.c
> +++ b/drivers/scsi/lpfc/lpfc_ct.c
> @@ -1074,8 +1074,25 @@ lpfc_vport_symbolic_node_name(struct lpfc_vport *vport, char *symbol,
>
> lpfc_decode_firmware_rev(vport->phba, fwrev, 0);
>
> - n = snprintf(symbol, size, "Emulex %s FV%s DV%s",
> - vport->phba->ModelName, fwrev, lpfc_release_version);
> + n = snprintf(symbol, size, "Emulex %s", vport->phba->ModelName);
> +
> + if (size < n)
> + return n;
> + n += snprintf(symbol + n, size - n, " FV%s", fwrev);
> +
> + if (size < n)
> + return n;
> + n += snprintf(symbol + n, size - n, " DV%s", lpfc_release_version);
> +
> + if (size < n)
> + return n;
> + n += snprintf(symbol + n, size - n, " HN:%s", init_utsname()->nodename);
> +
> + /* Note :- OS name is "Linux" as per requirement BZ168199. */
> + if (size < n)
> + return n;
> + n += snprintf(symbol + n, size - n, " OS:%s", init_utsname()->sysname);
> +
> return n;
> }
Care to disclose which bugzilla contains BZ168199?
Sebastian
next prev parent reply other threads:[~2015-04-05 12:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-03 21:12 [PATCH 10/21] lpfc: Fix provide host name and OS name in RSNN-NN FC-GS command James Smart
2015-04-05 12:07 ` Sebastian Herbszt [this message]
2015-04-07 19:23 ` James Smart
2015-04-10 6:13 ` Hannes Reinecke
-- strict thread matches above, loose matches on Subject: below --
2015-02-05 19:24 James Smart
2015-02-06 12:20 ` Tomas Henzl
2015-02-16 16:22 ` James Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150405140748.00007e42@localhost \
--to=herbszt@gmx.de \
--cc=james.smart@emulex.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).