public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH scsi] aacraid: aac_src_intr_message() can be static
  2015-04-10  8:53 [scsi:misc 24/67] drivers/scsi/aacraid/src.c:49:13: sparse: symbol 'aac_src_intr_message' was not declared. Should it be static? kbuild test robot
@ 2015-04-10  8:53 ` kbuild test robot
  2015-04-13 11:04   ` Mahesh Rajashekhara
  0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2015-04-10  8:53 UTC (permalink / raw)
  To: Mahesh Rajashekhara
  Cc: kbuild-all, James Bottomley, Adaptec OEM Raid Solutions,
	James E.J. Bottomley, linux-scsi, linux-kernel


Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 src.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/aacraid/src.c b/drivers/scsi/aacraid/src.c
index 50f181f..79a3ed1 100644
--- a/drivers/scsi/aacraid/src.c
+++ b/drivers/scsi/aacraid/src.c
@@ -46,7 +46,7 @@
 
 static int aac_src_get_sync_status(struct aac_dev *dev);
 
-irqreturn_t aac_src_intr_message(int irq, void *dev_id)
+static irqreturn_t aac_src_intr_message(int irq, void *dev_id)
 {
 	struct aac_msix_ctx *ctx;
 	struct aac_dev *dev;

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [scsi:misc 24/67] drivers/scsi/aacraid/src.c:49:13: sparse: symbol 'aac_src_intr_message' was not declared. Should it be static?
@ 2015-04-10  8:53 kbuild test robot
  2015-04-10  8:53 ` [PATCH scsi] aacraid: aac_src_intr_message() can be static kbuild test robot
  0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2015-04-10  8:53 UTC (permalink / raw)
  To: Mahesh Rajashekhara
  Cc: kbuild-all, James Bottomley, Adaptec OEM Raid Solutions,
	James E.J. Bottomley, linux-scsi, linux-kernel

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git misc
head:   eef77801b56b098cd7e1daf8a03854dd203a051c
commit: 495c021767bd78c998a46cf8cdd7a4ebf3a9cfd1 [24/67] aacraid: MSI-x support
reproduce:
  # apt-get install sparse
  git checkout 495c021767bd78c998a46cf8cdd7a4ebf3a9cfd1
  make ARCH=x86_64 allmodconfig
  make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/scsi/aacraid/src.c:49:13: sparse: symbol 'aac_src_intr_message' was not declared. Should it be static?
>> drivers/scsi/aacraid/src.c:452:55: sparse: restricted __le16 degrades to integer
   drivers/scsi/aacraid/src.c:487:57: sparse: incorrect type in assignment (different base types)
   drivers/scsi/aacraid/src.c:487:57:    expected restricted __le32 [usertype] SenderFibAddress
   drivers/scsi/aacraid/src.c:487:57:    got unsigned int [unsigned] [usertype] <noident>
   drivers/scsi/aacraid/src.c:499:31: sparse: incorrect type in assignment (different base types)
   drivers/scsi/aacraid/src.c:499:31:    expected unsigned int [unsigned] [usertype] Handle
   drivers/scsi/aacraid/src.c:499:31:    got restricted __le32 [usertype] <noident>
   drivers/scsi/aacraid/src.c:500:36: sparse: incorrect type in assignment (different base types)
   drivers/scsi/aacraid/src.c:500:36:    expected unsigned long long [unsigned] [usertype] HostAddress
   drivers/scsi/aacraid/src.c:500:36:    got restricted __le64 [usertype] <noident>
   drivers/scsi/aacraid/src.c:501:29: sparse: incorrect type in assignment (different base types)
   drivers/scsi/aacraid/src.c:501:29:    expected unsigned int [unsigned] [usertype] Size
   drivers/scsi/aacraid/src.c:501:29:    got restricted __le32 [usertype] <noident>
   drivers/scsi/aacraid/src.c:611:5: sparse: symbol 'aac_src_select_comm' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation

^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH scsi] aacraid: aac_src_intr_message() can be static
  2015-04-10  8:53 ` [PATCH scsi] aacraid: aac_src_intr_message() can be static kbuild test robot
@ 2015-04-13 11:04   ` Mahesh Rajashekhara
  0 siblings, 0 replies; 3+ messages in thread
From: Mahesh Rajashekhara @ 2015-04-13 11:04 UTC (permalink / raw)
  To: kbuild test robot
  Cc: kbuild-all@01.org, James Bottomley, Adaptec OEM Raid Solutions,
	James E.J. Bottomley, linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org, Mahesh Rajashekhara

Acked-by: Mahesh Rajashekhara <Mahesh.Rajashekhara@pmcs.com>

-----Original Message-----
From: kbuild test robot [mailto:fengguang.wu@intel.com] 
Sent: Friday, April 10, 2015 2:24 PM
To: Mahesh Rajashekhara
Cc: kbuild-all@01.org; James Bottomley; Adaptec OEM Raid Solutions; James E.J. Bottomley; linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: [PATCH scsi] aacraid: aac_src_intr_message() can be static


Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 src.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/aacraid/src.c b/drivers/scsi/aacraid/src.c index 50f181f..79a3ed1 100644
--- a/drivers/scsi/aacraid/src.c
+++ b/drivers/scsi/aacraid/src.c
@@ -46,7 +46,7 @@
 
 static int aac_src_get_sync_status(struct aac_dev *dev);
 
-irqreturn_t aac_src_intr_message(int irq, void *dev_id)
+static irqreturn_t aac_src_intr_message(int irq, void *dev_id)
 {
 	struct aac_msix_ctx *ctx;
 	struct aac_dev *dev;

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-04-13 11:04 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-10  8:53 [scsi:misc 24/67] drivers/scsi/aacraid/src.c:49:13: sparse: symbol 'aac_src_intr_message' was not declared. Should it be static? kbuild test robot
2015-04-10  8:53 ` [PATCH scsi] aacraid: aac_src_intr_message() can be static kbuild test robot
2015-04-13 11:04   ` Mahesh Rajashekhara

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox