linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: linux-scsi@vger.kernel.org,
	"James E.J. Bottomley" <JBottomley@parallels.com>
Cc: linux-kernel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 0/3] Fix return code for ioctl( BLKRRPART ) if device is down
Date: Thu, 16 Apr 2015 13:05:41 +0800	[thread overview]
Message-ID: <20150416050541.GC28705@ad.nay.redhat.com> (raw)
In-Reply-To: <55113DC7.7080002@redhat.com>

On Tue, 03/24 11:34, Paolo Bonzini wrote:
> 
> 
> On 24/03/2015 11:16, Fam Zheng wrote:
> > If issued right after link down, "blockdev --rereadpt" will be stuck for a
> > while and then return normally. Although the underlying capacity and partition
> > table are not correctly updated. And it means that userspace can't detect the
> > error at all.
> > 
> > Fix this by propargating the error of "read capacity" command through the
> > stack, so that the ioctl could fail with -EIO.
> > 
> > Fam Zheng (3):
> >   block: Return error in rescan_partitions if revalidating disk failed
> >   sd: Return error in sd_revalidate_disk if read capacity failed
> >   sd: Return -EIO if read capacity failed
> > 
> >  block/partition-generic.c |  6 +++---
> >  drivers/scsi/sd.c         | 22 +++++++++++++---------
> >  2 files changed, 16 insertions(+), 12 deletions(-)
> > 
> 
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

Ping?

> 
> Though patch 3 could be seen as a change in userspace ABI, so I'm less
> sure about it.
> 
> Paolo

      parent reply	other threads:[~2015-04-16  5:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-24 10:16 [PATCH 0/3] Fix return code for ioctl( BLKRRPART ) if device is down Fam Zheng
2015-03-24 10:16 ` [PATCH 1/3] block: Return error in rescan_partitions if revalidating disk failed Fam Zheng
2015-04-22  2:58   ` James Bottomley
2015-04-22  4:13     ` Fam Zheng
2015-03-24 10:16 ` [PATCH 2/3] sd: Return error in sd_revalidate_disk if read capacity failed Fam Zheng
2015-03-24 10:16 ` [PATCH 3/3] sd: Return -EIO " Fam Zheng
2015-03-24 10:34 ` [PATCH 0/3] Fix return code for ioctl( BLKRRPART ) if device is down Paolo Bonzini
2015-03-24 10:42   ` Fam Zheng
2015-04-16  5:05   ` Fam Zheng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150416050541.GC28705@ad.nay.redhat.com \
    --to=famz@redhat.com \
    --cc=JBottomley@parallels.com \
    --cc=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).