public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Don Brace <don.brace@pmcs.com>
To: scott.teel@pmcs.com, Kevin.Barnett@pmcs.com,
	james.bottomley@parallels.com, hch@infradead.org,
	Justin.Lindley@pmcs.com, brace@pmcs.com
Cc: linux-scsi@vger.kernel.org
Subject: [PATCH v4 36/43] hpsa: add interrupt number to /proc/interrupts interrupt name
Date: Thu, 16 Apr 2015 08:49:58 -0500	[thread overview]
Message-ID: <20150416134958.30238.62123.stgit@brunhilda> (raw)
In-Reply-To: <20150416134224.30238.66082.stgit@brunhilda>

From: Robert Elliott <elliott@hp.com>

Add the interrupt number to the interrupt names that
appear in /proc/interrupts, so they are unique

Also, delete the IRQ and DAC prints.  Other parts of the kernel
already print the IRQ assignments, and dual-address-cycle support
has not been interesting since the parallel PCI bus went from
32 to 64 bits wide.

Reviewed-by: Scott Teel <scott.teel@pmcs.com>
Reviewed-by: Kevin Barnett <kevin.barnett@pmcs.com>
Signed-off-by: Robert Elliott <elliott@hp.com>
Signed-off-by: Don Brace <don.brace@pmcs.com>
---
 drivers/scsi/hpsa.c |   20 ++++++++++++++------
 drivers/scsi/hpsa.h |    1 +
 2 files changed, 15 insertions(+), 6 deletions(-)

diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index fb755a8..83d7df0 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -7310,8 +7310,9 @@ static int hpsa_request_irqs(struct ctlr_info *h,
 	if (h->intr_mode == PERF_MODE_INT && h->msix_vector > 0) {
 		/* If performant mode and MSI-X, use multiple reply queues */
 		for (i = 0; i < h->msix_vector; i++) {
+			sprintf(h->intrname[i], "%s-msix%d", h->devname, i);
 			rc = request_irq(h->intr[i], msixhandler,
-					0, h->devname,
+					0, h->intrname[i],
 					&h->q[i]);
 			if (rc) {
 				int j;
@@ -7332,12 +7333,22 @@ static int hpsa_request_irqs(struct ctlr_info *h,
 	} else {
 		/* Use single reply pool */
 		if (h->msix_vector > 0 || h->msi_vector) {
+			if (h->msix_vector)
+				sprintf(h->intrname[h->intr_mode],
+					"%s-msix", h->devname);
+			else
+				sprintf(h->intrname[h->intr_mode],
+					"%s-msi", h->devname);
 			rc = request_irq(h->intr[h->intr_mode],
-				msixhandler, 0, h->devname,
+				msixhandler, 0,
+				h->intrname[h->intr_mode],
 				&h->q[h->intr_mode]);
 		} else {
+			sprintf(h->intrname[h->intr_mode],
+				"%s-intx", h->devname);
 			rc = request_irq(h->intr[h->intr_mode],
-				intxhandler, IRQF_SHARED, h->devname,
+				intxhandler, IRQF_SHARED,
+				h->intrname[h->intr_mode],
 				&h->q[h->intr_mode]);
 		}
 		irq_set_affinity_hint(h->intr[h->intr_mode], NULL);
@@ -7725,9 +7736,6 @@ reinit_after_soft_reset:
 	rc = hpsa_request_irqs(h, do_hpsa_intr_msi, do_hpsa_intr_intx);
 	if (rc)
 		goto clean3;	/* pci, lockup, aer/h */
-	dev_info(&pdev->dev, "%s: <0x%x> at IRQ %d%s using DAC\n",
-	       h->devname, pdev->device,
-	       h->intr[h->intr_mode], dac ? "" : " not");
 	rc = hpsa_alloc_cmd_pool(h);
 	if (rc)
 		goto clean4;	/* irq, pci, lockup, aer/h */
diff --git a/drivers/scsi/hpsa.h b/drivers/scsi/hpsa.h
index 7cb8586..3ec8934 100644
--- a/drivers/scsi/hpsa.h
+++ b/drivers/scsi/hpsa.h
@@ -220,6 +220,7 @@ struct ctlr_info {
 	int remove_in_progress;
 	/* Address of h->q[x] is passed to intr handler to know which queue */
 	u8 q[MAX_REPLY_QUEUES];
+	char intrname[MAX_REPLY_QUEUES][16];	/* "hpsa0-msix00" names */
 	u32 TMFSupportFlags; /* cache what task mgmt funcs are supported. */
 #define HPSATMF_BITS_SUPPORTED  (1 << 0)
 #define HPSATMF_PHYS_LUN_RESET  (1 << 1)


  parent reply	other threads:[~2015-04-16 13:51 UTC|newest]

Thread overview: 131+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-16 13:46 [PATCH v4 00/43] hpsa update Don Brace
2015-04-16 13:46 ` [PATCH v4 01/43] hpsa: add masked physical devices into h->dev[] array Don Brace
2015-04-17 12:52   ` Hannes Reinecke
2015-04-17 13:15   ` Tomas Henzl
2015-04-16 13:46 ` [PATCH v4 02/43] hpsa: clean up host, channel, target, lun prints Don Brace
2015-04-17 12:53   ` Hannes Reinecke
2015-04-17 13:15   ` Tomas Henzl
2015-04-16 13:46 ` [PATCH v4 03/43] hpsa: rework controller command submission Don Brace
2015-04-17 12:57   ` Hannes Reinecke
2015-04-16 13:47 ` [PATCH v4 04/43] hpsa: clean up aborts Don Brace
2015-04-17 12:59   ` Hannes Reinecke
2015-04-17 13:19   ` Tomas Henzl
2015-04-16 13:47 ` [PATCH v4 05/43] hpsa: decrement h->commands_outstanding in fail_all_outstanding_cmds Don Brace
2015-04-17 13:00   ` Hannes Reinecke
2015-04-17 13:20   ` Tomas Henzl
2015-04-16 13:47 ` [PATCH v4 06/43] hpsa: hpsa decode sense data for io and tmf Don Brace
2015-04-17 13:03   ` Hannes Reinecke
2015-04-17 13:23   ` Tomas Henzl
2015-04-16 13:47 ` [PATCH v4 07/43] hpsa: allow lockup detected to be viewed via sysfs Don Brace
2015-04-17 13:04   ` Hannes Reinecke
2015-04-17 13:23   ` Tomas Henzl
2015-04-16 13:47 ` [PATCH v4 08/43] hpsa: make function names consistent Don Brace
2015-04-17 13:04   ` Hannes Reinecke
2015-04-17 13:24   ` Tomas Henzl
2015-04-16 13:47 ` [PATCH v4 09/43] hpsa: factor out hpsa_init_cmd function Don Brace
2015-04-17 13:05   ` Hannes Reinecke
2015-04-17 13:26   ` Tomas Henzl
2015-04-16 13:47 ` [PATCH v4 10/43] hpsa: do not ignore return value of hpsa_register_scsi Don Brace
2015-04-17 13:05   ` Hannes Reinecke
2015-04-17 13:26   ` Tomas Henzl
2015-04-16 13:47 ` [PATCH v4 11/43] hpsa: try resubmitting down raid path on task set full Don Brace
2015-04-17 13:06   ` Hannes Reinecke
2015-04-17 13:26   ` Tomas Henzl
2015-04-16 13:47 ` [PATCH v4 12/43] hpsa: factor out hpsa_ioaccel_submit function Don Brace
2015-04-17 13:07   ` Hannes Reinecke
2015-04-17 13:27   ` Tomas Henzl
2015-04-16 13:47 ` [PATCH v4 13/43] hpsa: print accurate SSD Smart Path Enabled status Don Brace
2015-04-17 13:07   ` Hannes Reinecke
2015-04-17 13:27   ` Tomas Henzl
2015-04-16 13:47 ` [PATCH v4 14/43] hpsa: use ioaccel2 path to submit IOs to physical drives in HBA mode Don Brace
2015-04-17 13:08   ` Hannes Reinecke
2015-04-17 13:28   ` Tomas Henzl
2015-04-16 13:48 ` [PATCH v4 15/43] hpsa: Get queue depth from identify physical bmic for physical disks Don Brace
2015-04-17 13:09   ` Hannes Reinecke
2015-04-17 13:28   ` Tomas Henzl
2015-04-16 13:48 ` [PATCH v4 16/43] hpsa: break hpsa_free_irqs_and_disable_msix into two functions Don Brace
2015-04-17 13:10   ` Hannes Reinecke
2015-04-17 13:28   ` Tomas Henzl
2015-04-16 13:48 ` [PATCH v4 17/43] hpsa: clean up error handling Don Brace
2015-04-17 13:11   ` Hannes Reinecke
2015-04-17 13:29   ` Tomas Henzl
2015-04-16 13:48 ` [PATCH v4 18/43] hpsa: refactor freeing of resources into more logical functions Don Brace
2015-04-17 13:12   ` Hannes Reinecke
2015-04-17 13:29   ` Tomas Henzl
2015-04-16 13:48 ` [PATCH v4 19/43] hpsa: add ioaccel sg chaining for the ioaccel2 path Don Brace
2015-04-17 13:14   ` Hannes Reinecke
2015-04-22 19:12     ` brace
2015-04-23  5:50       ` Hannes Reinecke
2015-04-23  7:39         ` hch
2015-04-16 13:48 ` [PATCH v4 20/43] hpsa: add more ioaccel2 error handling, including underrun statuses Don Brace
2015-04-17 13:15   ` Hannes Reinecke
2015-04-16 13:48 ` [PATCH v4 21/43] hpsa: do not check cmd_alloc return value - it cannnot return NULL Don Brace
2015-04-17 13:16   ` Hannes Reinecke
2015-04-17 13:32   ` Tomas Henzl
2015-04-16 13:48 ` [PATCH v4 22/43] hpsa: correct return values from driver functions Don Brace
2015-04-17 13:17   ` Hannes Reinecke
2015-04-17 13:33   ` Tomas Henzl
2015-04-17 13:39   ` Tomas Henzl
2015-04-16 13:48 ` [PATCH v4 23/43] hpsa: clean up driver init Don Brace
2015-04-17 13:19   ` Hannes Reinecke
2015-04-17 13:39   ` Tomas Henzl
2015-04-16 13:48 ` [PATCH v4 24/43] hpsa: clean up some error reporting output in abort handler Don Brace
2015-04-17 13:20   ` Hannes Reinecke
2015-04-17 13:39   ` Tomas Henzl
2015-04-16 13:48 ` [PATCH v4 25/43] hpsa: do not print ioaccel2 warning messages about unusual completions Don Brace
2015-04-17 13:21   ` Hannes Reinecke
2015-04-17 13:40   ` Tomas Henzl
2015-04-16 13:49 ` [PATCH v4 26/43] hpsa: add support sending aborts to physical devices via the ioaccel2 path Don Brace
2015-04-17 13:22   ` Hannes Reinecke
2015-04-17 13:40   ` Tomas Henzl
2015-04-16 13:49 ` [PATCH v4 27/43] hpsa: use helper routines for finishing commands Don Brace
2015-04-17 13:23   ` Hannes Reinecke
2015-04-17 13:42   ` Tomas Henzl
2015-04-16 13:49 ` [PATCH v4 28/43] hpsa: don't return abort request until target is complete Don Brace
2015-04-17 13:24   ` Hannes Reinecke
2015-04-17 13:43   ` Tomas Henzl
2015-04-16 13:49 ` [PATCH v4 29/43] hpsa: refactor and rework support for sending TEST_UNIT_READY Don Brace
2015-04-17 13:25   ` Hannes Reinecke
2015-04-17 13:43   ` Tomas Henzl
2015-04-16 13:49 ` [PATCH v4 30/43] hpsa: performance tweak for hpsa_scatter_gather() Don Brace
2015-04-17 13:26   ` Hannes Reinecke
2015-04-17 13:43   ` Tomas Henzl
2015-04-16 13:49 ` [PATCH v4 31/43] hpsa: call pci_release_regions after pci_disable_device Don Brace
2015-04-17 13:27   ` Hannes Reinecke
2015-04-17 13:44   ` Tomas Henzl
2015-04-16 13:49 ` [PATCH v4 32/43] hpsa: skip free_irq calls if irqs are not allocated Don Brace
2015-04-17 13:29   ` Hannes Reinecke
2015-04-17 13:44   ` Tomas Henzl
2015-04-16 13:49 ` [PATCH v4 33/43] hpsa: cleanup for init_one step 2 in kdump Don Brace
2015-04-17 13:29   ` Hannes Reinecke
2015-04-17 13:45   ` Tomas Henzl
2015-04-16 13:49 ` [PATCH v4 34/43] hpsa: fix try_soft_reset error handling Don Brace
2015-04-17 13:29   ` Hannes Reinecke
2015-04-17 13:45   ` Tomas Henzl
2015-04-16 13:49 ` [PATCH v4 35/43] hpsa: create workqueue after the driver is ready for use Don Brace
2015-04-17 13:30   ` Hannes Reinecke
2015-04-17 13:46   ` Tomas Henzl
2015-04-16 13:49 ` Don Brace [this message]
2015-04-17 13:31   ` [PATCH v4 36/43] hpsa: add interrupt number to /proc/interrupts interrupt name Hannes Reinecke
2015-04-17 13:47   ` Tomas Henzl
2015-04-16 13:50 ` [PATCH v4 37/43] hpsa: use block layer tag for command allocation Don Brace
2015-04-17 13:33   ` Hannes Reinecke
2015-04-17 13:50   ` Tomas Henzl
2015-04-16 13:50 ` [PATCH v4 38/43] hpsa: use scsi host_no as hpsa controller number Don Brace
2015-04-17 13:34   ` Hannes Reinecke
2015-04-17 13:50   ` Tomas Henzl
2015-04-16 13:50 ` [PATCH v4 39/43] hpsa: propagate the error code in hpsa_kdump_soft_reset Don Brace
2015-04-17 13:34   ` Hannes Reinecke
2015-04-17 13:51   ` Tomas Henzl
2015-04-16 13:50 ` [PATCH v4 40/43] hpsa: cleanup reset Don Brace
2015-04-17 13:36   ` Hannes Reinecke
2015-04-17 13:51   ` Tomas Henzl
2015-04-16 13:50 ` [PATCH v4 41/43] hpsa: change driver version Don Brace
2015-04-17 13:36   ` Hannes Reinecke
2015-04-17 13:52   ` Tomas Henzl
2015-04-16 13:50 ` [PATCH v4 42/43] hpsa: add PMC to copyright Don Brace
2015-04-17  1:00   ` Elliott, Robert (Server Storage)
2015-04-17 13:36   ` Hannes Reinecke
2015-04-16 13:50 ` [PATCH v4 43/43] hpsa: add in new controller id Don Brace
2015-04-17 13:37   ` Hannes Reinecke
2015-04-17 13:52   ` Tomas Henzl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150416134958.30238.62123.stgit@brunhilda \
    --to=don.brace@pmcs.com \
    --cc=Justin.Lindley@pmcs.com \
    --cc=Kevin.Barnett@pmcs.com \
    --cc=brace@pmcs.com \
    --cc=hch@infradead.org \
    --cc=james.bottomley@parallels.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=scott.teel@pmcs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox