From: Christoph Hellwig <hch@infradead.org>
To: Sumit.Saxena@avagotech.com
Cc: linux-scsi@vger.kernel.org, thenzl@redhat.com,
martin.petersen@oracle.com, hch@infradead.org,
jbottomley@parallels.com, kashyap.desai@avagotech.com
Subject: Re: [PATCH RESEND 1/18] megaraid_sas : Add separate function for setting up IRQs
Date: Tue, 21 Apr 2015 03:33:30 -0700 [thread overview]
Message-ID: <20150421103330.GA8920@infradead.org> (raw)
In-Reply-To: <201504201234.t3KCYg04016312@palmhbs0.lsi.com>
On Mon, Apr 20, 2015 at 06:02:30PM +0530, Sumit.Saxena@avagotech.com wrote:
> This patch will create separate function for setting up IRQs and enable interrupts after adapter's initialization.
The structure of megasas_setup_irqs clearly suggest it should be two
functions: one for the traditional case, and one for MSI-X.
The irq unregister case should get a similar factoring.
Additionally the changelog needs an explanation on why you move around
the code that registeres interrupts as well as the
->instancet->enable_intr call.
next prev parent reply other threads:[~2015-04-21 10:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-20 12:32 [PATCH RESEND 1/18] megaraid_sas : Add separate function for setting up IRQs Sumit.Saxena
2015-04-21 10:17 ` Hannes Reinecke
2015-04-21 10:33 ` Christoph Hellwig [this message]
2015-04-21 11:41 ` Sumit Saxena
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150421103330.GA8920@infradead.org \
--to=hch@infradead.org \
--cc=Sumit.Saxena@avagotech.com \
--cc=jbottomley@parallels.com \
--cc=kashyap.desai@avagotech.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=thenzl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox