From: Sebastian Herbszt <herbszt@gmx.de>
To: Andy Grover <agrover@redhat.com>
Cc: target-devel@vger.kernel.org, linux-scsi@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
James Smart <james.smart@emulex.com>,
Sebastian Herbszt <herbszt@gmx.de>
Subject: Re: [RFC PATCH 2/2] lpfc: add target hooks
Date: Sat, 25 Apr 2015 00:50:17 +0200 [thread overview]
Message-ID: <20150425005017.000078d5@localhost> (raw)
In-Reply-To: <552DAFE0.7050109@redhat.com>
Andy Grover wrote:
> On 04/12/2015 07:17 AM, Sebastian Herbszt wrote:
> > Add target hooks.
> >
> > Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
>
> > +#ifdef LPFC_TARGET_MODE
> > +#include "lpfc_target_api.h"
> > +#include "lpfc_target_api_base.h"
> > +#endif
>
> Hi, great to see new fabrics posted.
The code is actually not new. This is just yet another attempt to get
it upstream [1].
> There are a great many ifdefs like this. Are they strictly necessary?
None should be necessary. I left them in to allow an easy way to test
the code without impact on the initiator part of lpfc.
> Thanks -- Regards -- Andy
[1] http://www.spinics.net/lists/kernel/msg1060127.html
Sebastian
next prev parent reply other threads:[~2015-04-24 22:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-12 14:17 [RFC PATCH 2/2] lpfc: add target hooks Sebastian Herbszt
2015-04-15 0:25 ` Andy Grover
2015-04-24 22:50 ` Sebastian Herbszt [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-06-14 15:26 Sebastian Herbszt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150425005017.000078d5@localhost \
--to=herbszt@gmx.de \
--cc=agrover@redhat.com \
--cc=hch@infradead.org \
--cc=james.smart@emulex.com \
--cc=linux-scsi@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).