Re: [PATCH v3 1/2] libahci: Add support to handle HOST_IRQ_STAT as edge trigger latch.

Sergei Shtylyov
2015-05-04T13:08:08Z

Hello.

On 5/3/2015 6:33 PM, Suman Tripathi wrote:

> This patch adds the support to handle HOST_IRQ_STAT as edge trigger
> latch.

> Signed-off-by: Suman Tripathi <stripathi@apm.com>
> ---
> drivers/ata/ahci.h | 2 ++
> drivers/ata/libahci.c | 19 +++++++++++++++++++
> 2 files changed, 21 insertions(+)

> diff --git a/drivers/ata/ahci.h b/drivers/ata/ahci.h
> index 71262e0..2df2237 100644
> --- a/drivers/ata/ahci.h
> +++ b/drivers/ata/ahci.h
[...]
> +++ b/drivers/ata/libahci.c
> @@ -1879,6 +1879,25 @@ static irqreturn_t ahci_single_irq_intr(int irq, void *dev_instance)
> */
> writel(irq_stat, mmio + HOST_IRQ_STAT);
>
> + /*
> + * HOST_IRQ_STAT behaves as edge trigger latch. When HOST_IRQ_STAT
> + * detects a egde from PORT_IRQ_STAT, it happens to loose interrupts

s/loose/lose/.

MBR, Sergei