From: Christoph Hellwig <hch@infradead.org>
To: "Seymour, Shane M" <shane.seymour@hp.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"Laurence Oberman (loberman@redhat.com)" <loberman@redhat.com>,
"Kai.Makisara@kolumbus.fi" <Kai.Makisara@kolumbus.fi>,
"James E.J. Bottomley (JBottomley@parallels.com)"
<JBottomley@parallels.com>,
"Elliott, Robert (Server Storage)" <Elliott@hp.com>
Subject: Re: [PATCH v7] st implement tape statistics
Date: Tue, 5 May 2015 10:42:41 -0700 [thread overview]
Message-ID: <20150505174241.GA6033@infradead.org> (raw)
In-Reply-To: <DDB9C85B850785449757F9914A034FCB3BFA45A3@G9W0766.americas.hpqcorp.net>
The subject line should be
"st: implement tape statistics" to fit the general scheme.
On Thu, Apr 23, 2015 at 08:06:50AM +0000, Seymour, Shane M wrote:
> Signed-off-by: Shane Seymour <shane.seymour@hp.com>
> Tested-by: Shane Seymour <shane.seymour@hp.com>
Tested-by is usually used for other testers, not the patch author.
Where is the description of what these staistics do and what you need
them for? A patch with just a subject and a signoff is unlikely to get
applied.
A lot of the code seems to be duplicates of what we do in block
layer statistics, I wonder if there is any way to share that code?
next prev parent reply other threads:[~2015-05-05 17:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-23 8:06 [PATCH v7] st implement tape statistics Seymour, Shane M
2015-05-05 17:42 ` Christoph Hellwig [this message]
2015-05-06 1:11 ` Seymour, Shane M
2015-05-06 4:30 ` Christoph Hellwig
2015-05-06 15:05 ` Seymour, Shane M
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150505174241.GA6033@infradead.org \
--to=hch@infradead.org \
--cc=Elliott@hp.com \
--cc=JBottomley@parallels.com \
--cc=Kai.Makisara@kolumbus.fi \
--cc=linux-scsi@vger.kernel.org \
--cc=loberman@redhat.com \
--cc=shane.seymour@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox