From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v7] st implement tape statistics Date: Tue, 5 May 2015 10:42:41 -0700 Message-ID: <20150505174241.GA6033@infradead.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from bombadil.infradead.org ([198.137.202.9]:57088 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751393AbbEERmn (ORCPT ); Tue, 5 May 2015 13:42:43 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: "Seymour, Shane M" Cc: "linux-scsi@vger.kernel.org" , "Laurence Oberman (loberman@redhat.com)" , "Kai.Makisara@kolumbus.fi" , "James E.J. Bottomley (JBottomley@parallels.com)" , "Elliott, Robert (Server Storage)" The subject line should be "st: implement tape statistics" to fit the general scheme. On Thu, Apr 23, 2015 at 08:06:50AM +0000, Seymour, Shane M wrote: > Signed-off-by: Shane Seymour > Tested-by: Shane Seymour Tested-by is usually used for other testers, not the patch author. Where is the description of what these staistics do and what you need them for? A patch with just a subject and a signoff is unlikely to get applied. A lot of the code seems to be duplicates of what we do in block layer statistics, I wonder if there is any way to share that code?