public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: "Seymour, Shane M" <shane.seymour@hp.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"Laurence Oberman (loberman@redhat.com)" <loberman@redhat.com>,
	"Kai.Makisara@kolumbus.fi" <Kai.Makisara@kolumbus.fi>,
	"James E.J. Bottomley (JBottomley@parallels.com)"
	<JBottomley@parallels.com>,
	"Elliott, Robert (Server Storage)" <Elliott@hp.com>
Subject: Re: [PATCH v7] st implement tape statistics
Date: Tue, 5 May 2015 21:30:47 -0700	[thread overview]
Message-ID: <20150506043047.GA2077@infradead.org> (raw)
In-Reply-To: <DDB9C85B850785449757F9914A034FCB3BFA96F7@G9W0766.americas.hpqcorp.net>

On Wed, May 06, 2015 at 01:11:26AM +0000, Seymour, Shane M wrote:
> "The tape driver does not have access to the block device i/o statistics because the tapes are not block devices but character devices. They use the Linux block subsystem enough to do i/o but this does not include access to the statistics counters.
> 
> ... One alternative is, of course, to tie the st driver more into the Linux block device system. I have looked into this several times but have never seen how to do this in a simple enough way."

I know the architecture pretty well, but the question is if we can
export some of that functionality so that it works for character devices
nodes that driver a request_queue.  Note that it was formualted as a
questions as thast change seems obvious but might not be feasible for
one reason or another.  If you looked at it and consider it not doable
or at least not worthwhile for good reasons document those in the patch
description.

  reply	other threads:[~2015-05-06  4:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-23  8:06 [PATCH v7] st implement tape statistics Seymour, Shane M
2015-05-05 17:42 ` Christoph Hellwig
2015-05-06  1:11   ` Seymour, Shane M
2015-05-06  4:30     ` Christoph Hellwig [this message]
2015-05-06 15:05       ` Seymour, Shane M

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150506043047.GA2077@infradead.org \
    --to=hch@infradead.org \
    --cc=Elliott@hp.com \
    --cc=JBottomley@parallels.com \
    --cc=Kai.Makisara@kolumbus.fi \
    --cc=linux-scsi@vger.kernel.org \
    --cc=loberman@redhat.com \
    --cc=shane.seymour@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox