From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v7] st implement tape statistics Date: Tue, 5 May 2015 21:30:47 -0700 Message-ID: <20150506043047.GA2077@infradead.org> References: <20150505174241.GA6033@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from bombadil.infradead.org ([198.137.202.9]:41889 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759060AbbEFEat (ORCPT ); Wed, 6 May 2015 00:30:49 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: "Seymour, Shane M" Cc: Christoph Hellwig , "linux-scsi@vger.kernel.org" , "Laurence Oberman (loberman@redhat.com)" , "Kai.Makisara@kolumbus.fi" , "James E.J. Bottomley (JBottomley@parallels.com)" , "Elliott, Robert (Server Storage)" On Wed, May 06, 2015 at 01:11:26AM +0000, Seymour, Shane M wrote: > "The tape driver does not have access to the block device i/o statistics because the tapes are not block devices but character devices. They use the Linux block subsystem enough to do i/o but this does not include access to the statistics counters. > > ... One alternative is, of course, to tie the st driver more into the Linux block device system. I have looked into this several times but have never seen how to do this in a simple enough way." I know the architecture pretty well, but the question is if we can export some of that functionality so that it works for character devices nodes that driver a request_queue. Note that it was formualted as a questions as thast change seems obvious but might not be feasible for one reason or another. If you looked at it and consider it not doable or at least not worthwhile for good reasons document those in the patch description.