linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 01/15] lpfc: The lpfc driver does not issue RFF_ID and RFT_ID in the correct sequence
@ 2015-05-21 17:55 James Smart
  2015-05-24 11:27 ` Sebastian Herbszt
  0 siblings, 1 reply; 2+ messages in thread
From: James Smart @ 2015-05-21 17:55 UTC (permalink / raw)
  To: linux-scsi


The lpfc driver does not issue RFF_ID and RFT_ID in the correct sequence

Signed-off-by: Dick Kennedy <dick.kennedy@avagotech.com>
Signed-off-by: James Smart <james.smart@avagotech.com>
---
 drivers/scsi/lpfc/lpfc_hbadisc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c
index 2500f15..f2db89f 100644
--- a/drivers/scsi/lpfc/lpfc_hbadisc.c
+++ b/drivers/scsi/lpfc/lpfc_hbadisc.c
@@ -3868,11 +3868,11 @@ out:
 
 	if (vport->port_state < LPFC_VPORT_READY) {
 		/* Link up discovery requires Fabric registration. */
-		lpfc_ns_cmd(vport, SLI_CTNS_RFF_ID, 0, 0); /* Do this first! */
 		lpfc_ns_cmd(vport, SLI_CTNS_RNN_ID, 0, 0);
 		lpfc_ns_cmd(vport, SLI_CTNS_RSNN_NN, 0, 0);
 		lpfc_ns_cmd(vport, SLI_CTNS_RSPN_ID, 0, 0);
 		lpfc_ns_cmd(vport, SLI_CTNS_RFT_ID, 0, 0);
+		lpfc_ns_cmd(vport, SLI_CTNS_RFF_ID, 0, 0);
 
 		/* Issue SCR just before NameServer GID_FT Query */
 		lpfc_issue_els_scr(vport, SCR_DID, 0);
-- 
1.7.11.7


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2 01/15] lpfc: The lpfc driver does not issue RFF_ID and RFT_ID in the correct sequence
  2015-05-21 17:55 [PATCH v2 01/15] lpfc: The lpfc driver does not issue RFF_ID and RFT_ID in the correct sequence James Smart
@ 2015-05-24 11:27 ` Sebastian Herbszt
  0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Herbszt @ 2015-05-24 11:27 UTC (permalink / raw)
  To: James Smart; +Cc: linux-scsi, Sebastian Herbszt

James Smart wrote:
> 
> The lpfc driver does not issue RFF_ID and RFT_ID in the correct sequence
> 
> Signed-off-by: Dick Kennedy <dick.kennedy@avagotech.com>
> Signed-off-by: James Smart <james.smart@avagotech.com>
> ---
>  drivers/scsi/lpfc/lpfc_hbadisc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c
> index 2500f15..f2db89f 100644
> --- a/drivers/scsi/lpfc/lpfc_hbadisc.c
> +++ b/drivers/scsi/lpfc/lpfc_hbadisc.c
> @@ -3868,11 +3868,11 @@ out:
>  
>  	if (vport->port_state < LPFC_VPORT_READY) {
>  		/* Link up discovery requires Fabric registration. */
> -		lpfc_ns_cmd(vport, SLI_CTNS_RFF_ID, 0, 0); /* Do this first! */
>  		lpfc_ns_cmd(vport, SLI_CTNS_RNN_ID, 0, 0);
>  		lpfc_ns_cmd(vport, SLI_CTNS_RSNN_NN, 0, 0);
>  		lpfc_ns_cmd(vport, SLI_CTNS_RSPN_ID, 0, 0);
>  		lpfc_ns_cmd(vport, SLI_CTNS_RFT_ID, 0, 0);
> +		lpfc_ns_cmd(vport, SLI_CTNS_RFF_ID, 0, 0);
>  
>  		/* Issue SCR just before NameServer GID_FT Query */
>  		lpfc_issue_els_scr(vport, SCR_DID, 0);

Reviewed-by: Sebastian Herbszt <herbszt@gmx.de>

Sebastian

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-05-24 11:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-21 17:55 [PATCH v2 01/15] lpfc: The lpfc driver does not issue RFF_ID and RFT_ID in the correct sequence James Smart
2015-05-24 11:27 ` Sebastian Herbszt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).