From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Nic Bellinger <nab@daterainc.com>,
target-devel@vger.kernel.org, linux-scsi@vger.kernel.org,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 4/6] target: Send UA on ALUA target port group change
Date: Fri, 19 Jun 2015 15:05:19 +0200 [thread overview]
Message-ID: <20150619130519.GA7783@lst.de> (raw)
In-Reply-To: <1434009689-112909-5-git-send-email-hare@suse.de>
> --- a/drivers/target/target_core_alua.c
> +++ b/drivers/target/target_core_alua.c
> @@ -1880,12 +1880,19 @@ static void core_alua_put_tg_pt_gp_from_name(
> static void __target_attach_tg_pt_gp(struct se_lun *lun,
> struct t10_alua_tg_pt_gp *tg_pt_gp)
> {
> + struct se_dev_entry *se_deve;
> +
> assert_spin_locked(&lun->lun_tg_pt_gp_lock);
>
> spin_lock(&tg_pt_gp->tg_pt_gp_lock);
> lun->lun_tg_pt_gp = tg_pt_gp;
> list_add_tail(&lun->lun_tg_pt_gp_link, &tg_pt_gp->tg_pt_gp_lun_list);
> tg_pt_gp->tg_pt_gp_members++;
> + spin_lock_bh(&lun->lun_deve_lock);
> + list_for_each_entry(se_deve, &lun->lun_deve_list, lun_link)
> + core_scsi3_ua_allocate(se_deve, 0x3f,
> + ASCQ_3FH_INQUIRY_DATA_HAS_CHANGED);
> + spin_unlock_bh(&lun->lun_deve_lock);
> spin_unlock(&tg_pt_gp->tg_pt_gp_lock);
Taking a _bh lock inside a regular spinlock is completely broken.
Fortunately I don't think lun_deve_lock needs to disable bottom halves,
but this needs to be fixed first.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
next prev parent reply other threads:[~2015-06-19 13:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 8:01 [PATCH 0/6] target: Update UA handling Hannes Reinecke
2015-06-11 8:01 ` [PATCH 1/6] target_core_alua: Correct UA handling when switching states Hannes Reinecke
2015-06-11 8:01 ` [PATCH 2/6] target: Remove 'ua_nacl' pointer from se_ua structure Hannes Reinecke
2015-06-11 8:01 ` [PATCH 3/6] target: use 'se_dev_entry' when allocating UAs Hannes Reinecke
2015-06-17 6:06 ` Nicholas A. Bellinger
2015-06-17 6:20 ` Hannes Reinecke
2015-06-11 8:01 ` [PATCH 4/6] target: Send UA on ALUA target port group change Hannes Reinecke
2015-06-19 13:05 ` Christoph Hellwig [this message]
2015-06-19 13:09 ` Hannes Reinecke
2015-06-19 13:13 ` Christoph Hellwig
2015-06-23 7:54 ` Nicholas A. Bellinger
2015-06-11 8:01 ` [PATCH 5/6] target: Send UA upon LUN RESET tmr completion Hannes Reinecke
2015-06-19 13:06 ` Christoph Hellwig
2015-06-19 13:07 ` Hannes Reinecke
2015-06-23 7:54 ` Nicholas A. Bellinger
2015-06-11 8:01 ` [PATCH 6/6] target: Send UA when changing LUN inventory Hannes Reinecke
2015-06-19 13:07 ` Christoph Hellwig
2015-06-19 13:10 ` Hannes Reinecke
2015-06-23 7:56 ` Nicholas A. Bellinger
2015-06-17 6:10 ` [PATCH 0/6] target: Update UA handling Nicholas A. Bellinger
2015-06-17 6:25 ` Hannes Reinecke
2015-06-17 7:01 ` Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150619130519.GA7783@lst.de \
--to=hch@lst.de \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@daterainc.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).