From: Christoph Hellwig <hch@infradead.org>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: linux-scsi@vger.kernel.org, Long Li <longli@microsoft.com>,
"K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
"James E.J. Bottomley" <JBottomley@odin.com>,
devel@linuxdriverproject.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: storvsc: make INQUIRY response SPC-compliant
Date: Fri, 3 Jul 2015 09:19:03 -0700 [thread overview]
Message-ID: <20150703161903.GA20449@infradead.org> (raw)
In-Reply-To: <1435741448-29070-1-git-send-email-vkuznets@redhat.com>
On Wed, Jul 01, 2015 at 11:04:08AM +0200, Vitaly Kuznetsov wrote:
> SPC-2/3/4 specs state that "The standard INQUIRY data (see table ...)
> shall contain at least 36 bytes". Hyper-V host doesn't always honor this
> requirement, e.g. when there is no physical device present at a particular
> LUN host sets Peripheral qualifier to 011b and Additional length to 0
> (thus making the reply 5-bytes long). Upper level SCSI stack complains
> with 'INQUIRY result too short (5), using 36'. Fix the issue by mangling
> Additional length field in host's reply at the driver level.
This looks like a big mess, and usage of phys_to_virt is not generally
safe to start with.
If HyperV really is that broken the warning seems correct, but if you
really have to get rid of it we could add a blist flag to not issue
the warning in the core code instead of hacking around it in the driver.
next prev parent reply other threads:[~2015-07-03 16:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-01 9:04 [PATCH] scsi: storvsc: make INQUIRY response SPC-compliant Vitaly Kuznetsov
2015-07-03 16:19 ` Christoph Hellwig [this message]
2015-07-03 16:28 ` KY Srinivasan
2015-07-07 15:01 ` Vitaly Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150703161903.GA20449@infradead.org \
--to=hch@infradead.org \
--cc=JBottomley@odin.com \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).