From: Christoph Hellwig <hch@infradead.org>
To: Sagi Grimberg <sagig@mellanox.com>
Cc: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Hannes Reinecke <hare@suse.de>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Bart Van Assche <bart.vanassche@sandisk.com>,
"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
James Bottomley <James.Bottomley@HansenPartnership.com>
Subject: Re: [PATCH 3/3] target: Return descriptor format sense data
Date: Tue, 14 Jul 2015 00:17:03 -0700 [thread overview]
Message-ID: <20150714071703.GC31117@infradead.org> (raw)
In-Reply-To: <1436697423-20611-4-git-send-email-sagig@mellanox.com>
On Sun, Jul 12, 2015 at 01:37:03PM +0300, Sagi Grimberg wrote:
> Fixed size sense data information field is only 32 bits which
> means the sector (64 bits) information will be truncated.
>
> Move to descriptor format sense data to correctly report full
> sector information.
I think this needs to be a tunable as old initiators might not be
able to cope with descriptor sense data. My idea was to only turn
it own if the LU is large enough to need it. Initiators that can
deal with large LUs by using READ CAPACITY (16) and READ/WRITE (16)
should be able to handle descriptor style sense data as well.
next prev parent reply other threads:[~2015-07-14 7:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-12 10:37 [PATCH 0/3] Descriptor format sense data Sagi Grimberg
2015-07-12 10:37 ` [PATCH 1/3] scsi: Fix wrong additional sense length in descriptor format Sagi Grimberg
2015-07-13 14:05 ` Hannes Reinecke
2015-07-14 0:52 ` Martin K. Petersen
2015-07-12 10:37 ` [PATCH 2/3] scsi: Protect against buffer possible overflow in scsi_set_sense_information Sagi Grimberg
2015-07-14 0:54 ` Martin K. Petersen
2015-07-12 10:37 ` [PATCH 3/3] target: Return descriptor format sense data Sagi Grimberg
2015-07-14 0:57 ` Martin K. Petersen
2015-07-14 7:17 ` Christoph Hellwig [this message]
2015-07-14 8:21 ` Martin K. Petersen
2015-07-14 11:59 ` Sagi Grimberg
2015-07-14 13:34 ` Bart Van Assche
2015-07-14 14:40 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150714071703.GC31117@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bart.vanassche@sandisk.com \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nab@linux-iscsi.org \
--cc=sagig@mellanox.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox