From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v1 4/4] libiscsi: Use scsi helper to set information descriptor Date: Wed, 15 Jul 2015 01:30:35 -0700 Message-ID: <20150715083035.GD6684@infradead.org> References: <1436946939-19415-1-git-send-email-sagig@mellanox.com> <1436946939-19415-5-git-send-email-sagig@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1436946939-19415-5-git-send-email-sagig@mellanox.com> Sender: target-devel-owner@vger.kernel.org To: Sagi Grimberg Cc: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, Christoph Hellwig , "Martin K. Petersen" , Hannes Reinecke , Bart Van Assche , Mike Christie , James Bottomley , "Nicholas A. Bellinger" List-Id: linux-scsi@vger.kernel.org On Wed, Jul 15, 2015 at 10:55:39AM +0300, Sagi Grimberg wrote: > In case encountered a PI error, use scsi_set_sense_information > instead of open coding information descriptor format. > > Signed-off-by: Sagi Grimberg Looks good, Reviewed-by: Christoph Hellwig