* [PATCH] scsi: fcoe: Convert use of __constant_htons to htons
@ 2015-08-19 5:48 Vaishali Thakkar
2015-09-01 22:43 ` Vasu Dev
0 siblings, 1 reply; 2+ messages in thread
From: Vaishali Thakkar @ 2015-08-19 5:48 UTC (permalink / raw)
To: Vasu Dev; +Cc: James E.J. Bottomley, linux-scsi, fcoe-devel, linux-kernel
In little endian cases, the macro htons unfolds to __swab16 which
provides special case for constants. In big endian cases,
__constant_htons and htons expand directly to the same expression.
So, replace __constant_htons with htons with the goal of getting
rid of the definition of __constant_htons completely.
The semantic patch that performs this transformation is as follows:
@@expression x;@@
- __constant_htons(x)
+ htons(x)
Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
---
drivers/scsi/fcoe/fcoe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
index ec193a8..d3eb80c 100644
--- a/drivers/scsi/fcoe/fcoe.c
+++ b/drivers/scsi/fcoe/fcoe.c
@@ -364,7 +364,7 @@ static int fcoe_interface_setup(struct fcoe_interface *fcoe,
* on the ethertype for the given device
*/
fcoe->fcoe_packet_type.func = fcoe_rcv;
- fcoe->fcoe_packet_type.type = __constant_htons(ETH_P_FCOE);
+ fcoe->fcoe_packet_type.type = htons(ETH_P_FCOE);
fcoe->fcoe_packet_type.dev = netdev;
dev_add_pack(&fcoe->fcoe_packet_type);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: fcoe: Convert use of __constant_htons to htons
2015-08-19 5:48 [PATCH] scsi: fcoe: Convert use of __constant_htons to htons Vaishali Thakkar
@ 2015-09-01 22:43 ` Vasu Dev
0 siblings, 0 replies; 2+ messages in thread
From: Vasu Dev @ 2015-09-01 22:43 UTC (permalink / raw)
To: Vaishali Thakkar
Cc: fcoe-devel-s9riP+hp16TNLxjTenLetw, James E.J. Bottomley,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-scsi-u79uwXL29TY76Z2rM5mHXA
On Wed, 2015-08-19 at 11:18 +0530, Vaishali Thakkar wrote:
> In little endian cases, the macro htons unfolds to __swab16 which
> provides special case for constants. In big endian cases,
> __constant_htons and htons expand directly to the same expression.
> So, replace __constant_htons with htons with the goal of getting
> rid of the definition of __constant_htons completely.
>
> The semantic patch that performs this transformation is as follows:
>
> @@expression x;@@
>
> - __constant_htons(x)
> + htons(x)
>
> Signed-off-by: Vaishali Thakkar <vthakkar1994-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> drivers/scsi/fcoe/fcoe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
> index ec193a8..d3eb80c 100644
> --- a/drivers/scsi/fcoe/fcoe.c
> +++ b/drivers/scsi/fcoe/fcoe.c
> @@ -364,7 +364,7 @@ static int fcoe_interface_setup(struct fcoe_interface *fcoe,
> * on the ethertype for the given device
> */
> fcoe->fcoe_packet_type.func = fcoe_rcv;
> - fcoe->fcoe_packet_type.type = __constant_htons(ETH_P_FCOE);
> + fcoe->fcoe_packet_type.type = htons(ETH_P_FCOE);
> fcoe->fcoe_packet_type.dev = netdev;
> dev_add_pack(&fcoe->fcoe_packet_type);
>
Acked-by: Vasu Dev <vasu.dev-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-01 22:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-19 5:48 [PATCH] scsi: fcoe: Convert use of __constant_htons to htons Vaishali Thakkar
2015-09-01 22:43 ` Vasu Dev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox