From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Herbszt Subject: Re: [PATCH 03/14] lpfc: in sli3 use configured sg_seg_cnt for sg_tablesize Date: Tue, 1 Sep 2015 23:27:57 +0200 Message-ID: <20150901232757.00000e1f@localhost> References: <55e4bd8a.9Holn3dFdEAEsMk9%james.smart@avagotech.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from mout.gmx.net ([212.227.17.22]:55623 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750969AbbIAV2J (ORCPT ); Tue, 1 Sep 2015 17:28:09 -0400 In-Reply-To: <55e4bd8a.9Holn3dFdEAEsMk9%james.smart@avagotech.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: James Smart Cc: linux-scsi@vger.kernel.org James Smart wrote: > > From: Bodo Stroesser > > Hi James, > > We had some performance problems with RAID systems connected to LPe12k. > AFAICS, the reason is a small bug in lpfc.ko, causing the IO-size to > be smaller than expected. > > The patch below fixes it for us. > > Please CC me, I'm not on the list. > > Best regards > Bodo > > ------------------------------------------------------ > > Currently the module parameter lpfc_sg_seg_count does not have effect > for sli3 devices. > > In lpfc_sli_driver_resource_setup(), which is used for sli3, the code > writes the configured sg_seg_cnt into lpfc_template.sg_tablesize. > But lpfc_template is the template used for sli4 only. Thus the value should > correctly be written to lpfc_template_s3->sg_tablesize. > > This patch is for kernel 4.1-rc5, but is tested with lpfc 10.2.405.26 only. > > Signed-off-by: Bodo Stroesser > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c > index da9b6fc..81bfb2d 100644 > --- a/drivers/scsi/lpfc/lpfc_init.c > +++ b/drivers/scsi/lpfc/lpfc_init.c > @@ -4994,7 +4994,7 @@ lpfc_sli_driver_resource_setup(struct lpfc_hba *phba) > > /* Initialize the host templates the configured values. */ > lpfc_vport_template.sg_tablesize = phba->cfg_sg_seg_cnt; > - lpfc_template.sg_tablesize = phba->cfg_sg_seg_cnt; > + lpfc_template_s3.sg_tablesize = phba->cfg_sg_seg_cnt; > > /* There are going to be 2 reserved BDEs: 1 FCP cmnd + 1 FCP rsp */ > if (phba->cfg_enable_bg) { Reviewed-by: Sebastian Herbszt