* [PATCH] ibmvsci: make parameters max_id and max_channel read-only
@ 2015-09-09 15:21 Laurent Vivier
2015-09-09 15:33 ` Brian King
2015-09-10 0:55 ` David Gibson
0 siblings, 2 replies; 3+ messages in thread
From: Laurent Vivier @ 2015-09-09 15:21 UTC (permalink / raw)
To: linux-scsi, linux-kernel, Tyrel Datwyler; +Cc: dgibson, thuth, lvivier
The value of the parameter is never re-read by the driver,
so a new value is ignored. Let know the user he
can't modify it by removing writable attribute.
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
index 6a41c36..3e76490 100644
--- a/drivers/scsi/ibmvscsi/ibmvscsi.c
+++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
@@ -105,9 +105,9 @@ MODULE_AUTHOR("Dave Boutcher");
MODULE_LICENSE("GPL");
MODULE_VERSION(IBMVSCSI_VERSION);
-module_param_named(max_id, max_id, int, S_IRUGO | S_IWUSR);
+module_param_named(max_id, max_id, int, S_IRUGO);
MODULE_PARM_DESC(max_id, "Largest ID value for each channel");
-module_param_named(max_channel, max_channel, int, S_IRUGO | S_IWUSR);
+module_param_named(max_channel, max_channel, int, S_IRUGO);
MODULE_PARM_DESC(max_channel, "Largest channel value");
module_param_named(init_timeout, init_timeout, int, S_IRUGO | S_IWUSR);
MODULE_PARM_DESC(init_timeout, "Initialization timeout in seconds");
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ibmvsci: make parameters max_id and max_channel read-only
2015-09-09 15:21 [PATCH] ibmvsci: make parameters max_id and max_channel read-only Laurent Vivier
@ 2015-09-09 15:33 ` Brian King
2015-09-10 0:55 ` David Gibson
1 sibling, 0 replies; 3+ messages in thread
From: Brian King @ 2015-09-09 15:33 UTC (permalink / raw)
To: Laurent Vivier, linux-scsi, linux-kernel, Tyrel Datwyler; +Cc: dgibson, thuth
On 09/09/2015 10:21 AM, Laurent Vivier wrote:
> The value of the parameter is never re-read by the driver,
> so a new value is ignored. Let know the user he
> can't modify it by removing writable attribute.
Reviewed-by: Brian King <brking@linux.vnet.ibm.com>
--
Brian King
Power Linux I/O
IBM Linux Technology Center
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ibmvsci: make parameters max_id and max_channel read-only
2015-09-09 15:21 [PATCH] ibmvsci: make parameters max_id and max_channel read-only Laurent Vivier
2015-09-09 15:33 ` Brian King
@ 2015-09-10 0:55 ` David Gibson
1 sibling, 0 replies; 3+ messages in thread
From: David Gibson @ 2015-09-10 0:55 UTC (permalink / raw)
To: Laurent Vivier; +Cc: linux-scsi, linux-kernel, Tyrel Datwyler, thuth
[-- Attachment #1: Type: text/plain, Size: 447 bytes --]
On Wed, 9 Sep 2015 17:21:00 +0200
Laurent Vivier <lvivier@redhat.com> wrote:
> The value of the parameter is never re-read by the driver,
> so a new value is ignored. Let know the user he
> can't modify it by removing writable attribute.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: David Gibson <dgibson@redhat.com>
--
David Gibson <dgibson@redhat.com>
Senior Software Engineer, Virtualization, Red Hat
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-10 0:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-09 15:21 [PATCH] ibmvsci: make parameters max_id and max_channel read-only Laurent Vivier
2015-09-09 15:33 ` Brian King
2015-09-10 0:55 ` David Gibson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).