linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Paul Mackerras <paulus@ozlabs.org>
Cc: Christoph Hellwig <hch@lst.de>,
	James Bottomley <James.Bottomley@HansenPartnership.com>,
	linux-scsi@vger.kernel.org, Tejun Heo <tj@kernel.org>
Subject: Re: Bugs in multipath scsi in 4.3-rc2
Date: Fri, 2 Oct 2015 14:52:24 +0200	[thread overview]
Message-ID: <20151002125224.GA14899@lst.de> (raw)
In-Reply-To: <20151001043453.GA2893@iris.ozlabs.ibm.com>

On Thu, Oct 01, 2015 at 02:34:54PM +1000, Paul Mackerras wrote:
> I still get the warning:

Ok, I sent you the wrong patch.  scsi_dh_add_device is the function that
needs to switch to use __scsi_dh_lookup.  New version below:

diff --git a/drivers/scsi/scsi_dh.c b/drivers/scsi/scsi_dh.c
index edb044a..cc9ea81 100644
--- a/drivers/scsi/scsi_dh.c
+++ b/drivers/scsi/scsi_dh.c
@@ -226,7 +226,7 @@ int scsi_dh_add_device(struct scsi_device *sdev)
 
 	drv = scsi_dh_find_driver(sdev);
 	if (drv)
-		devinfo = scsi_dh_lookup(drv);
+		devinfo = __scsi_dh_lookup(drv);
 	if (devinfo)
 		err = scsi_dh_handler_attach(sdev, devinfo);
 	return err;

  reply	other threads:[~2015-10-02 12:52 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-25 12:16 Bugs in multipath scsi in 4.3-rc2 Paul Mackerras
2015-09-25 15:18 ` Christoph Hellwig
2015-09-25 17:31   ` James Bottomley
2015-09-30 15:14     ` Christoph Hellwig
2015-09-30 21:53       ` Tejun Heo
2015-09-30 22:34         ` James Bottomley
2015-10-02 12:56           ` Christoph Hellwig
2015-10-02 13:25             ` James Bottomley
2015-10-02 13:34               ` Christoph Hellwig
2015-10-02 13:44                 ` James Bottomley
2015-10-04  7:45                   ` Christoph Hellwig
2015-10-12 12:45                     ` Hannes Reinecke
2015-10-12 14:39                       ` Christoph Hellwig
2015-10-12 19:29                         ` Mike Snitzer
2015-10-12 19:36                           ` Christoph Hellwig
2015-10-13  6:00                             ` Hannes Reinecke
2015-10-13 11:52                               ` Christoph Hellwig
2015-10-12 14:51                       ` James Bottomley
2015-10-01  4:34       ` Paul Mackerras
2015-10-02 12:52         ` Christoph Hellwig [this message]
2015-10-08  4:59           ` Paul Mackerras
2015-09-25 16:28 ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151002125224.GA14899@lst.de \
    --to=hch@lst.de \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=paulus@ozlabs.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).