From: Christoph Hellwig <hch@infradead.org>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Christoph Hellwig <hch@infradead.org>,
Hannes Reinecke <hare@suse.de>,
"James E.J. Bottomley" <JBottomley@odin.com>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: RFC: reduce CONFIG_SCSI_CONSTANTS impact by 4k
Date: Sun, 4 Oct 2015 01:02:17 -0700 [thread overview]
Message-ID: <20151004080217.GA22816@infradead.org> (raw)
In-Reply-To: <87bncf1u4p.fsf@rasmusvillemoes.dk>
On Sun, Oct 04, 2015 at 12:09:58AM +0200, Rasmus Villemoes wrote:
> On Sat, Oct 03 2015, Christoph Hellwig <hch@infradead.org> wrote:
>
> > Hi Rasmus,
> >
> > I like this idea. But maybe it's also time to just move the constants
> > to a plain text file and auto-generate C headers from them? That way
> > the format in which they can be edited is decoupled from the
> > representation in the kernel image.
>
> Well, I don't really have an opinion on that part.
>
> In the meantime, I got another idea for doubling the saving to 8k. It
> requires a few more code changes and is perhaps also more hacky. 2/2
> would be something like below. Please let me know which version you'd
> prefer, and I'll send both patches properly.
I don't think the new version is too bad, and the saving is impressive.
So I'd opt for the new one.
next prev parent reply other threads:[~2015-10-04 8:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-30 17:30 RFC: reduce CONFIG_SCSI_CONSTANTS impact by 4k Rasmus Villemoes
2015-10-03 17:14 ` Christoph Hellwig
2015-10-03 22:09 ` Rasmus Villemoes
2015-10-04 8:02 ` Christoph Hellwig [this message]
2015-10-05 9:26 ` [PATCH 0/2] scsi: reduce CONFIG_SCSI_CONSTANTS=y impact by 8k Rasmus Villemoes
2015-10-05 9:26 ` [PATCH 1/2] scsi: move Additional Sense Codes to separate file Rasmus Villemoes
2015-10-05 14:05 ` Bart Van Assche
2015-10-06 15:27 ` Rasmus Villemoes
2015-10-17 22:12 ` Rasmus Villemoes
2015-10-05 9:26 ` [PATCH 2/2] scsi: reduce CONFIG_SCSI_CONSTANTS=y impact by 8k Rasmus Villemoes
2015-10-05 14:11 ` Bart Van Assche
2015-10-06 15:31 ` Rasmus Villemoes
2015-10-06 1:32 ` RFC: reduce CONFIG_SCSI_CONSTANTS impact by 4k Julian Calaby
2015-10-06 15:39 ` Rasmus Villemoes
2015-10-06 23:01 ` Julian Calaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151004080217.GA22816@infradead.org \
--to=hch@infradead.org \
--cc=JBottomley@odin.com \
--cc=hare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).