From: Christoph Hellwig <hch@infradead.org>
To: Sreekanth Reddy <sreekanth.reddy@avagotech.com>
Cc: jejb@kernel.org, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org, JBottomley@Parallels.com,
Sathya.Prakash@avagotech.com, chaitra.basappa@avagotech.com,
suganath-prabu.subramani@avagotech.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/18] mpt2sas, mpt3sas: Combine mpt2sas and mpt3sas driver code base
Date: Tue, 6 Oct 2015 02:46:29 -0700 [thread overview]
Message-ID: <20151006094629.GA3863@infradead.org> (raw)
In-Reply-To: <1443628038-13552-1-git-send-email-Sreekanth.Reddy@avagotech.com>
This series seems to miss patch 5 which actually removes the mpt2sas
driver - it probably was too large for the list. I also don't really like
the -DMPT2_SAS thing, but given that diver merges are painful I'd suggest
to merge it as-is and then see if we can convert it to build a mpt_common
module used by both drivers later.
Acked-by: Christoph Hellwig <hch@lst.de>
On Wed, Sep 30, 2015 at 09:17:00PM +0530, Sreekanth Reddy wrote:
> Combined mpt2sas and mpt3sas driver code base in such a way that
> still we can generate the two driver modules
> (i.e. mpt2sas.ko for SAS2 HBA's & mpt3sas.ko for SAS3 HBA's) individualy.
>
> Sreekanth Reddy (18):
> mpt2sas: Use mpi headers from mpt3sas
> mpt3sas : Added mpt2sas driver definitions
> mpt3sas: Move Gen3 HBA's device registration with PCI, SML and IOCTL
> related API's to a separate file
> mpt2sas: Created mpt2sas_module.c file in which Gen2 HBA's are
> registers with PCI, SML and IOCTLs
> mpt2sas: Removed .c and .h files from mpt2sas driver
> mpt3sas: Define 'hba_mpi_version_belonged' IOC variable
> mpt2sas, mpt3sas : Removed SCSI_MPTXSAS_LOGGING entry from Kconfig
> mpt3sas: For an IO, build MPI SGL LIST on GEN2 HBA's and build IEEE
> SGL LIST on GEN3 HBA's
> mpt3as: Don't send PHYDISK_HIDDEN Raid Action request on SAS2 HBA's
> mpt3sas: Manage MSIX vectors according to HBA device type
> mpt3sas: fix for driver fails EEH, recovery from injected pci bus
> error
> mpt3sas : Ported WarpDrive product SSS6200 support
> mpt3sas: Ported the providing sysfs attribute to report Backup Rail
> Monitor Status
> mpt3sas: Refcount sas_device objects and fix unsafe list usage
> mpt3sas: Refcount fw_events and fix unsafe list usage
> mpt3sas: Added OEMs Gen2 PnP ID Branding names
> mpt3sas: setpci reset kernel oops fix
> mpt2sas, mpt3sas: Update the driver versions
>
> drivers/scsi/mpt2sas/Kconfig | 6 -
> drivers/scsi/mpt2sas/Makefile | 18 +-
> drivers/scsi/mpt2sas/mpi/mpi2.h | 1170 ----
> drivers/scsi/mpt2sas/mpi/mpi2_cnfg.h | 3068 -----------
> drivers/scsi/mpt2sas/mpi/mpi2_init.h | 461 --
> drivers/scsi/mpt2sas/mpi/mpi2_ioc.h | 1708 ------
> drivers/scsi/mpt2sas/mpi/mpi2_raid.h | 366 --
> drivers/scsi/mpt2sas/mpi/mpi2_sas.h | 288 -
> drivers/scsi/mpt2sas/mpi/mpi2_tool.h | 481 --
> drivers/scsi/mpt2sas/mpi/mpi2_type.h | 61 -
> drivers/scsi/mpt2sas/mpt2sas_base.c | 4899 -----------------
> drivers/scsi/mpt2sas/mpt2sas_base.h | 1235 -----
> drivers/scsi/mpt2sas/mpt2sas_config.c | 1527 ------
> drivers/scsi/mpt2sas/mpt2sas_ctl.c | 3101 -----------
> drivers/scsi/mpt2sas/mpt2sas_ctl.h | 419 --
> drivers/scsi/mpt2sas/mpt2sas_debug.h | 182 -
> drivers/scsi/mpt2sas/mpt2sas_module.c | 281 +
> drivers/scsi/mpt2sas/mpt2sas_scsih.c | 8855 ------------------------------
> drivers/scsi/mpt2sas/mpt2sas_transport.c | 2173 --------
> drivers/scsi/mpt2sas/mpt2sas_warpdrive.c | 338 ++
> drivers/scsi/mpt3sas/Kconfig | 6 -
> drivers/scsi/mpt3sas/Makefile | 3 +-
> drivers/scsi/mpt3sas/mpt3sas_base.c | 663 ++-
> drivers/scsi/mpt3sas/mpt3sas_base.h | 256 +-
> drivers/scsi/mpt3sas/mpt3sas_config.c | 44 +-
> drivers/scsi/mpt3sas/mpt3sas_ctl.c | 200 +-
> drivers/scsi/mpt3sas/mpt3sas_ctl.h | 6 +-
> drivers/scsi/mpt3sas/mpt3sas_debug.h | 16 +-
> drivers/scsi/mpt3sas/mpt3sas_module.c | 253 +
> drivers/scsi/mpt3sas/mpt3sas_scsih.c | 1268 +++--
> drivers/scsi/mpt3sas/mpt3sas_transport.c | 18 +-
> 31 files changed, 2635 insertions(+), 30735 deletions(-)
> delete mode 100644 drivers/scsi/mpt2sas/mpi/mpi2.h
> delete mode 100644 drivers/scsi/mpt2sas/mpi/mpi2_cnfg.h
> delete mode 100644 drivers/scsi/mpt2sas/mpi/mpi2_init.h
> delete mode 100644 drivers/scsi/mpt2sas/mpi/mpi2_ioc.h
> delete mode 100644 drivers/scsi/mpt2sas/mpi/mpi2_raid.h
> delete mode 100644 drivers/scsi/mpt2sas/mpi/mpi2_sas.h
> delete mode 100644 drivers/scsi/mpt2sas/mpi/mpi2_tool.h
> delete mode 100644 drivers/scsi/mpt2sas/mpi/mpi2_type.h
> delete mode 100644 drivers/scsi/mpt2sas/mpt2sas_base.c
> delete mode 100644 drivers/scsi/mpt2sas/mpt2sas_base.h
> delete mode 100644 drivers/scsi/mpt2sas/mpt2sas_config.c
> delete mode 100644 drivers/scsi/mpt2sas/mpt2sas_ctl.c
> delete mode 100644 drivers/scsi/mpt2sas/mpt2sas_ctl.h
> delete mode 100644 drivers/scsi/mpt2sas/mpt2sas_debug.h
> create mode 100644 drivers/scsi/mpt2sas/mpt2sas_module.c
> delete mode 100644 drivers/scsi/mpt2sas/mpt2sas_scsih.c
> delete mode 100644 drivers/scsi/mpt2sas/mpt2sas_transport.c
> create mode 100644 drivers/scsi/mpt2sas/mpt2sas_warpdrive.c
> create mode 100644 drivers/scsi/mpt3sas/mpt3sas_module.c
>
> --
> 2.0.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
---end quoted text---
next prev parent reply other threads:[~2015-10-06 9:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-30 15:47 [PATCH 00/18] mpt2sas, mpt3sas: Combine mpt2sas and mpt3sas driver code base Sreekanth Reddy
2015-09-30 15:47 ` [PATCH 01/18] mpt2sas: Use mpi headers from mpt3sas Sreekanth Reddy
2015-10-04 7:51 ` Christoph Hellwig
2015-09-30 15:47 ` [PATCH 02/18] mpt3sas : Added mpt2sas driver definitions Sreekanth Reddy
2015-09-30 15:47 ` [PATCH 03/18] mpt3sas: Move Gen3 HBA's device registration with PCI, SML and IOCTL related API's to a separate file Sreekanth Reddy
2015-09-30 15:47 ` [PATCH 04/18] mpt2sas: Created mpt2sas_module.c file in which Gen2 HBA's are registers with PCI, SML and IOCTLs Sreekanth Reddy
2015-09-30 15:47 ` [PATCH 06/18] mpt3sas: Define 'hba_mpi_version_belonged' IOC variable Sreekanth Reddy
2015-09-30 15:47 ` [PATCH 07/18] mpt2sas, mpt3sas : Removed SCSI_MPTXSAS_LOGGING entry from Kconfig Sreekanth Reddy
2015-09-30 15:47 ` [PATCH 08/18] mpt3sas: For an IO, build MPI SGL LIST on GEN2 HBA's and build IEEE SGL LIST on GEN3 HBA's Sreekanth Reddy
2015-09-30 15:47 ` [PATCH 09/18] mpt3as: Don't send PHYDISK_HIDDEN Raid Action request on SAS2 HBA's Sreekanth Reddy
2015-09-30 15:47 ` [PATCH 10/18] mpt3sas: Manage MSIX vectors according to HBA device type Sreekanth Reddy
2015-09-30 15:47 ` [PATCH 11/18] mpt3sas: fix for driver fails EEH, recovery from injected pci bus error Sreekanth Reddy
2015-09-30 15:47 ` [PATCH 12/18] mpt3sas : Ported WarpDrive product SSS6200 support Sreekanth Reddy
2015-09-30 15:47 ` [PATCH 13/18] mpt3sas: Ported the providing sysfs attribute to report Backup Rail Monitor Status Sreekanth Reddy
2015-09-30 15:47 ` [PATCH 14/18] mpt3sas: Refcount sas_device objects and fix unsafe list usage Sreekanth Reddy
2015-09-30 15:47 ` [PATCH 15/18] mpt3sas: Refcount fw_events " Sreekanth Reddy
2015-09-30 15:47 ` [PATCH 16/18] mpt3sas: Added OEMs Gen2 PnP ID Branding names Sreekanth Reddy
2015-09-30 15:47 ` [PATCH 17/18] mpt3sas: setpci reset kernel oops fix Sreekanth Reddy
2015-09-30 15:47 ` [PATCH 18/18] mpt2sas, mpt3sas: Update the driver versions Sreekanth Reddy
2015-10-06 9:46 ` Christoph Hellwig [this message]
2015-10-06 10:29 ` [PATCH 00/18] mpt2sas, mpt3sas: Combine mpt2sas and mpt3sas driver code base Sreekanth Reddy
2015-10-06 17:13 ` James Bottomley
2015-10-07 9:18 ` Sreekanth Reddy
2015-10-08 14:00 ` Sreekanth Reddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151006094629.GA3863@infradead.org \
--to=hch@infradead.org \
--cc=JBottomley@Parallels.com \
--cc=Sathya.Prakash@avagotech.com \
--cc=chaitra.basappa@avagotech.com \
--cc=jejb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sreekanth.reddy@avagotech.com \
--cc=suganath-prabu.subramani@avagotech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).