Re: [PATCH v2 03/27] hpsa: remove unused hpsa_tag_discard_error_bits

Manoj Kumar
2015-11-05T15:30:31Z

Don:

Thanks for not redefining HPSA_PERF_ERROR_BITS.

Reviewed-by: Manoj Kumar <manoj@linux.vnet.ibm.com>

---
Manoj Kumar

On 11/4/2015 3:50 PM, Don Brace wrote:
> This function is no longer used.
>
> Reviewed-by: Tomas Henzl <thenzl@redhat.com>
> Reviewed-by: Hannes Reinecke <hare@suse.de>
> Signed-off-by: Don Brace <don.brace@pmcs.com>
> ---
> drivers/scsi/hpsa.c | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
> index 4085401..5a996273 100644
> --- a/drivers/scsi/hpsa.c
> +++ b/drivers/scsi/hpsa.c
> @@ -230,6 +230,7 @@ static int fill_cmd(struct CommandList *c, u8 cmd, struct ctlr_info *h,
> int cmd_type);
> static void hpsa_free_cmd_pool(struct ctlr_info *h);
> #define VPD_PAGE (1 << 8)
> +#define HPSA_SIMPLE_ERROR_BITS 0x03
>
> static int hpsa_scsi_queue_command(struct Scsi_Host *h, struct scsi_cmnd *cmd);
> static void hpsa_scan_start(struct Scsi_Host *);
> @@ -6436,16 +6437,6 @@ static inline void finish_cmd(struct CommandList *c)
> complete(c->waiting);
> }
>
> -
> -static inline u32 hpsa_tag_discard_error_bits(struct ctlr_info *h, u32 tag)
> -{
> -#define HPSA_PERF_ERROR_BITS ((1 << DIRECT_LOOKUP_SHIFT) - 1)
> -#define HPSA_SIMPLE_ERROR_BITS 0x03
> - if (unlikely(!(h->transMethod & CFGTBL_Trans_Performant)))
> - return tag & ~HPSA_SIMPLE_ERROR_BITS;
> - return tag & ~HPSA_PERF_ERROR_BITS;
> -}
> -
> /* process completion of an indexed ("direct lookup") command */
> static inline void process_indexed_cmd(struct ctlr_info *h,
> u32 raw_tag)
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>