From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH 4.1] target-core: fix return without a value Date: Tue, 10 Nov 2015 10:56:05 -0800 Message-ID: <20151110185605.GA15668@kroah.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail.linuxfoundation.org ([140.211.169.12]:59726 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751351AbbKJS4H (ORCPT ); Tue, 10 Nov 2015 13:56:07 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Mikulas Patocka Cc: Nicholas Bellinger , linux-stable@vger.kernel.org, Martin Svec , Alex Gorbachev , linux-scsi@vger.kernel.org, target-devel@vger.kernel.org On Tue, Nov 10, 2015 at 01:32:10PM -0500, Mikulas Patocka wrote: > Fix the warning drivers/target/target_core_pr.c:332:3: warning: 'return' > with no value, in function returning non-void [-Wreturn-type] > > The patch 35afa65642a9a88c81913377b93a3a66220f8b9d committed to 4.1.11 > adds a check if device_list is NULL. The patch adds a return statement > without a value to the function core_scsi3_pr_seq_non_holder that returns > int. > > Signed-off-by: Mikulas Patocka > > --- > drivers/target/target_core_pr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read Documentation/stable_kernel_rules.txt for how to do this properly.