From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Herbszt Subject: Re: [PATCH v2 1/2] scsi: lpfc: Use kzalloc instead of kmalloc Date: Mon, 23 Nov 2015 00:10:06 +0100 Message-ID: <20151123001006.00002fc3@localhost> References: <1445670416-3705-1-git-send-email-punitvara@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1445670416-3705-1-git-send-email-punitvara@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Punit Vara Cc: JBottomley@odin.com, don.brace@pmcs.com, storagedev@pmcs.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, mrochs@linux.vnet.ibm.com, James Smart , Sebastian Herbszt List-Id: linux-scsi@vger.kernel.org Punit Vara wrote: > This patch is to the lpfc_els.c which resolves following warning > reported by coccicheck: > > WARNING: kzalloc should be used for rdp_context, instead of > kmalloc/memset > > Signed-off-by: Punit Vara > --- > drivers/scsi/lpfc/lpfc_els.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c > index 36bf58b..9729ab1 100644 > --- a/drivers/scsi/lpfc/lpfc_els.c > +++ b/drivers/scsi/lpfc/lpfc_els.c > @@ -4990,13 +4990,12 @@ lpfc_els_rcv_rdp(struct lpfc_vport *vport, struct lpfc_iocbq *cmdiocb, > if (RDP_NPORT_ID_SIZE != > be32_to_cpu(rdp_req->nport_id_desc.length)) > goto rjt_logerr; > - rdp_context = kmalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL); > + rdp_context = kzalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL); > if (!rdp_context) { > rjt_err = LSRJT_UNABLE_TPC; > goto error; > } > > - memset(rdp_context, 0, sizeof(struct lpfc_rdp_context)); > cmd = &cmdiocb->iocb; > rdp_context->ndlp = lpfc_nlp_get(ndlp); > rdp_context->ox_id = cmd->unsli3.rcvsli3.ox_id; Reviewed-by: Sebastian Herbszt