From: Mike Snitzer <snitzer@redhat.com>
To: Hannes Reinecke <hare@suse.de>
Cc: Jens Axboe <axboe@fb.com>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
Christoph Hellwig <hch@lst.de>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Ewan Milne <emilne@redhat.com>, Jeff Moyer <jmoyer@redhat.com>
Subject: Re: block: Always check queue limits for cloned requests
Date: Thu, 26 Nov 2015 08:11:05 -0500 [thread overview]
Message-ID: <20151126131104.GA24297@redhat.com> (raw)
In-Reply-To: <1448524017-130967-1-git-send-email-hare@suse.de>
On Thu, Nov 26 2015 at 2:46am -0500,
Hannes Reinecke <hare@suse.de> wrote:
> When a cloned request is retried on other queues it always needs
> to be checked against the queue limits of that queue.
> Otherwise the calculations for nr_phys_segments might be wrong,
> leading to a crash in scsi_init_sgtable().
>
> To clarify this the patch renames blk_rq_check_limits()
> to blk_cloned_rq_check_limits() and removes the symbol
> export, as the new function should only be used for
> cloned requests and never exported.
>
> Cc: Mike Snitzer <snitzer@redhat.com>
> Cc: Ewan Milne <emilne@redhat.com>
> Cc: Jeff Moyer <jmoyer@redhat.com>
> Signed-off-by: Hannes Reinecke <hare@suse.de>
Patch looks good. Thanks for getting to the bottom of this.
Jens, please add these extra tags when you pick this up:
Fixes: e2a60da74 ("block: Clean up special command handling logic")
Cc: stable@vger.kernel.org # 3.7+
Acked-by: Mike Snitzer <snitzer@redhat.com>
next prev parent reply other threads:[~2015-11-26 13:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 7:46 [PATCH] block: Always check queue limits for cloned requests Hannes Reinecke
2015-11-26 13:11 ` Mike Snitzer [this message]
2015-11-29 11:49 ` Markus Trippelsdorf
2015-11-29 15:43 ` Hannes Reinecke
2015-11-29 16:15 ` Markus Trippelsdorf
2015-11-29 16:49 ` Mike Snitzer
2015-11-29 17:05 ` Markus Trippelsdorf
2015-11-30 6:11 ` Ming Lei
2015-11-30 7:12 ` Markus Trippelsdorf
2015-11-30 6:47 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151126131104.GA24297@redhat.com \
--to=snitzer@redhat.com \
--cc=axboe@fb.com \
--cc=emilne@redhat.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).