From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Snitzer Subject: Re: block: Always check queue limits for cloned requests Date: Thu, 26 Nov 2015 08:11:05 -0500 Message-ID: <20151126131104.GA24297@redhat.com> References: <1448524017-130967-1-git-send-email-hare@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1448524017-130967-1-git-send-email-hare@suse.de> Sender: linux-kernel-owner@vger.kernel.org To: Hannes Reinecke Cc: Jens Axboe , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Christoph Hellwig , "Martin K. Petersen" , Ewan Milne , Jeff Moyer List-Id: linux-scsi@vger.kernel.org On Thu, Nov 26 2015 at 2:46am -0500, Hannes Reinecke wrote: > When a cloned request is retried on other queues it always needs > to be checked against the queue limits of that queue. > Otherwise the calculations for nr_phys_segments might be wrong, > leading to a crash in scsi_init_sgtable(). > > To clarify this the patch renames blk_rq_check_limits() > to blk_cloned_rq_check_limits() and removes the symbol > export, as the new function should only be used for > cloned requests and never exported. > > Cc: Mike Snitzer > Cc: Ewan Milne > Cc: Jeff Moyer > Signed-off-by: Hannes Reinecke Patch looks good. Thanks for getting to the bottom of this. Jens, please add these extra tags when you pick this up: Fixes: e2a60da74 ("block: Clean up special command handling logic") Cc: stable@vger.kernel.org # 3.7+ Acked-by: Mike Snitzer