From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>,
James Bottomley <jbottomley@odin.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 3/5] scsi: make eh_eflags persistent
Date: Thu, 3 Dec 2015 17:55:42 +0100 [thread overview]
Message-ID: <20151203165542.GC14775@lst.de> (raw)
In-Reply-To: <1449127063-94512-4-git-send-email-hare@suse.de>
On Thu, Dec 03, 2015 at 08:17:41AM +0100, Hannes Reinecke wrote:
> To detect if a failed command has been retried we must not
> clear scmd->eh_eflags when EH finishes.
> The flag should be persistent throughout the lifetime
> of the command.
So we save away eh_eflags before potentially reusing the command and
the restore it. Seems seems fine, but an explanation of what this
fixes would be very helpful as the behavior seems to be around basically
forever.
next prev parent reply other threads:[~2015-12-03 16:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 7:17 [PATCH 0/5] SCSI EH cleanup Hannes Reinecke
2015-12-03 7:17 ` [PATCH 1/5] libsas: allow async aborts Hannes Reinecke
2015-12-03 8:17 ` Johannes Thumshirn
2015-12-03 7:17 ` [PATCH 2/5] scsi: make scsi_eh_scmd_add() always succeed Hannes Reinecke
2015-12-03 9:07 ` Johannes Thumshirn
2015-12-03 16:51 ` Christoph Hellwig
2015-12-03 7:17 ` [PATCH 3/5] scsi: make eh_eflags persistent Hannes Reinecke
2015-12-03 9:08 ` Johannes Thumshirn
2015-12-03 16:55 ` Christoph Hellwig [this message]
2015-12-03 7:17 ` [PATCH 4/5] scsi: make asynchronous aborts mandatory Hannes Reinecke
2015-12-03 9:13 ` Johannes Thumshirn
2015-12-03 7:17 ` [PATCH 5/5] scsi_error: do not escalate failed EH command Hannes Reinecke
2015-12-03 9:15 ` Johannes Thumshirn
-- strict thread matches above, loose matches on Subject: below --
2016-06-20 9:35 [PATCH 0/5] SCSI EH cleanup Hannes Reinecke
2016-06-20 9:35 ` [PATCH 3/5] scsi: make eh_eflags persistent Hannes Reinecke
2016-06-22 13:33 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151203165542.GC14775@lst.de \
--to=hch@lst.de \
--cc=hare@suse.de \
--cc=jbottomley@odin.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).