From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [patch] qla2xxx: fix a timeout loop Date: Thu, 17 Dec 2015 13:46:24 +0300 Message-ID: <20151217104624.GO5177@mwanda> References: <20151216110746.GB21018@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: kernel-janitors-owner@vger.kernel.org To: "Martin K. Petersen" Cc: qla2xxx-upstream@qlogic.com, Atul Deshmukh , "James E.J. Bottomley" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, Johannes Thumshirn List-Id: linux-scsi@vger.kernel.org On Wed, Dec 16, 2015 at 05:50:17PM -0500, Martin K. Petersen wrote: > >>>>> "Dan" == Dan Carpenter writes: > > Dan> After the loop we test for "if (!retries) " as a failure, but > Dan> actually the post-op here will end with retries set to -1. I have > Dan> fixed this by using a pre-op instead. > > Applied to 4.4/scsi-fixes. > The qlogic devs asked me to redo this patch but you have already applied it. Should I resend or redo it on top of the earlier patch. (James's tree was rebaseable for a day after a patch was "applied".) regards, dan carpenter