public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Herbszt <herbszt@gmx.de>
To: James Smart <james.smart@avagotech.com>
Cc: linux-scsi@vger.kernel.org, Sebastian Herbszt <herbszt@gmx.de>
Subject: Re: [PATCH 15/17] lpfc: Delete unnecessary checks before the function call "mempool_destroy"
Date: Thu, 17 Dec 2015 23:35:50 +0100	[thread overview]
Message-ID: <20151217233550.0000241b@localhost> (raw)
In-Reply-To: <5671efc6.ZwH5WdfbRkt48aQV%james.smart@avagotech.com>

James Smart wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> 
> The mempool_destroy() function tests whether its argument is NULL
> and then returns immediately. Thus the test around the calls is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> Signed-off-by: James Smart <james.smart@avagotech.com>

Reviewed-by: Sebastian Herbszt <herbszt@gmx.de>

      parent reply	other threads:[~2015-12-17 22:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-16 23:12 [PATCH 15/17] lpfc: Delete unnecessary checks before the function call "mempool_destroy" James Smart
2015-12-17  8:38 ` Hannes Reinecke
2015-12-17 22:35 ` Sebastian Herbszt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151217233550.0000241b@localhost \
    --to=herbszt@gmx.de \
    --cc=james.smart@avagotech.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox