From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [PATCH] SCSI-lpfc: Use a signed return type for two functions Date: Sat, 19 Dec 2015 23:17:07 +0300 Message-ID: <20151219201707.GR5284@mwanda> References: <5675A576.8020008@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <5675A576.8020008@users.sourceforge.net> Sender: linux-kernel-owner@vger.kernel.org To: SF Markus Elfring Cc: linux-scsi@vger.kernel.org, Dick Kennedy , "James E. J. Bottomley" , James Smart , "Martin K. Petersen" , LKML , kernel-janitors@vger.kernel.org, Julia Lawall List-Id: linux-scsi@vger.kernel.org It returns zero or negative error codes. The callers expect int. The current code is harmless. It should return an int. regards, dan carpenter