linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Finn Thain <fthain@telegraphics.com.au>
To: "James E.J. Bottomley" <JBottomley@odin.com>,
	Michael Schmitz <schmitzmic@gmail.com>,
	linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Russell King <linux@arm.linux.org.uk>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 19/77] ncr5380: Cleanup bogus {request, release}_region() calls
Date: Tue, 22 Dec 2015 12:17:57 +1100	[thread overview]
Message-ID: <20151222011743.205522414@telegraphics.com.au> (raw)
In-Reply-To: 20151222011737.980475848@telegraphics.com.au

[-- Attachment #1: ncr5380-cleanup-request_region-release_region --]
[-- Type: text/plain, Size: 2830 bytes --]

Commit 8b801ead3d7a ("[ARM] rpc: update Acorn SCSI drivers to modern ecard
interfaces") neglected to remove a request_region() call in cumana_1.c.

Commit eda32612f7b2 ("[PATCH] give all LLDD driver a ->release method") in
history/history.git added some pointless release_region() calls in dtc.c,
pas16.c and t128.c.

Fix these issues.

Signed-off-by: Finn Thain <fthain@telegraphics.com.au>

---
 drivers/scsi/arm/cumana_1.c |    6 ------
 drivers/scsi/dtc.c          |    2 --
 drivers/scsi/pas16.c        |    2 --
 drivers/scsi/t128.c         |    2 --
 4 files changed, 12 deletions(-)

Index: linux/drivers/scsi/arm/cumana_1.c
===================================================================
--- linux.orig/drivers/scsi/arm/cumana_1.c	2015-12-22 12:15:35.000000000 +1100
+++ linux/drivers/scsi/arm/cumana_1.c	2015-12-22 12:15:54.000000000 +1100
@@ -245,12 +245,6 @@ static int cumanascsi1_probe(struct expa
         priv(host)->ctrl = 0;
         writeb(0, priv(host)->base + CTRL);
 
-	host->n_io_port = 255;
-	if (!(request_region(host->io_port, host->n_io_port, "CumanaSCSI-1"))) {
-		ret = -EBUSY;
-		goto out_unmap;
-	}
-
 	ret = request_irq(host->irq, cumanascsi_intr, 0,
 			  "CumanaSCSI-1", host);
 	if (ret) {
Index: linux/drivers/scsi/dtc.c
===================================================================
--- linux.orig/drivers/scsi/dtc.c	2015-12-22 12:15:35.000000000 +1100
+++ linux/drivers/scsi/dtc.c	2015-12-22 12:15:54.000000000 +1100
@@ -423,8 +423,6 @@ static int dtc_release(struct Scsi_Host
 	if (shost->irq != NO_IRQ)
 		free_irq(shost->irq, shost);
 	NCR5380_exit(shost);
-	if (shost->io_port && shost->n_io_port)
-		release_region(shost->io_port, shost->n_io_port);
 	scsi_unregister(shost);
 	iounmap(hostdata->base);
 	return 0;
Index: linux/drivers/scsi/pas16.c
===================================================================
--- linux.orig/drivers/scsi/pas16.c	2015-12-22 12:15:35.000000000 +1100
+++ linux/drivers/scsi/pas16.c	2015-12-22 12:15:54.000000000 +1100
@@ -540,8 +540,6 @@ static int pas16_release(struct Scsi_Hos
 	if (shost->irq != NO_IRQ)
 		free_irq(shost->irq, shost);
 	NCR5380_exit(shost);
-	if (shost->io_port && shost->n_io_port)
-		release_region(shost->io_port, shost->n_io_port);
 	scsi_unregister(shost);
 	return 0;
 }
Index: linux/drivers/scsi/t128.c
===================================================================
--- linux.orig/drivers/scsi/t128.c	2015-12-22 12:15:35.000000000 +1100
+++ linux/drivers/scsi/t128.c	2015-12-22 12:15:54.000000000 +1100
@@ -255,8 +255,6 @@ static int t128_release(struct Scsi_Host
 	if (shost->irq != NO_IRQ)
 		free_irq(shost->irq, shost);
 	NCR5380_exit(shost);
-	if (shost->io_port && shost->n_io_port)
-		release_region(shost->io_port, shost->n_io_port);
 	scsi_unregister(shost);
 	iounmap(hostdata->base);
 	return 0;

  parent reply	other threads:[~2015-12-22  1:17 UTC|newest]

Thread overview: 156+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-22  1:17 [PATCH v3 00/77] More fixes, cleanup and modernization for NCR5380 drivers Finn Thain
2015-12-22  1:17 ` [PATCH v3 01/77] atari_scsi: Fix SCSI host ID setting Finn Thain
2015-12-22  1:17 ` [PATCH v3 02/77] ncr5380: Remove redundant static variable initializers Finn Thain
2015-12-22  1:17 ` [PATCH v3 03/77] ncr5380: Eliminate PDEBUG*, TDEBUG* and DTCDEBUG* macros Finn Thain
2015-12-22  1:17 ` [PATCH v3 04/77] ncr5380: Remove more pointless macros Finn Thain
2015-12-22  1:17 ` [PATCH v3 05/77] ncr5380: Remove NCR5380_local_declare and NCR5380_setup macros Finn Thain
2015-12-22  1:17 ` [PATCH v3 06/77] ncr5380: Remove NCR5380_instance_name macro Finn Thain
2015-12-22  1:17 ` [PATCH v3 07/77] ncr5380: Split NCR5380_init() into two functions Finn Thain
2015-12-22  1:17 ` [PATCH v3 08/77] ncr5380: Move NCR53C400-specific code Finn Thain
2015-12-22  1:17 ` [PATCH v3 09/77] atari_NCR5380: Reset bus on driver initialization if required Finn Thain
2015-12-22  1:17 ` [PATCH v3 10/77] atari_NCR5380: Remove RESET_BOOT, CONFIG_ATARI_SCSI_TOSHIBA_DELAY and CONFIG_ATARI_SCSI_RESET_BOOT Finn Thain
2015-12-22  1:17 ` [PATCH v3 11/77] ncr5380: Simplify bus reset handlers Finn Thain
2015-12-22  1:17 ` [PATCH v3 12/77] ncr5380: Remove unused hostdata->aborted flag Finn Thain
2015-12-22  1:17 ` [PATCH v3 13/77] ncr5380: Remove redundant register writes Finn Thain
2015-12-22  1:17 ` [PATCH v3 14/77] ncr5380: Use return instead of goto in NCR5380_select() Finn Thain
2015-12-22  1:17 ` [PATCH v3 15/77] ncr5380: Always escalate bad target time-out " Finn Thain
2015-12-22  1:17 ` [PATCH v3 16/77] ncr5380: Proceed with next command after NCR5380_select() calls scsi_done Finn Thain
2015-12-22  1:17 ` [PATCH v3 17/77] ncr5380: Keep BSY asserted when entering SELECTION phase Finn Thain
2015-12-22  7:01   ` Hannes Reinecke
2015-12-22  1:17 ` [PATCH v3 18/77] ncr5380: Eliminate USLEEP_WAITLONG delay Finn Thain
2015-12-22  7:05   ` Hannes Reinecke
2015-12-22 12:38     ` Finn Thain
2015-12-22 13:37       ` Hannes Reinecke
2015-12-22  1:17 ` Finn Thain [this message]
2015-12-22  7:05   ` [PATCH v3 19/77] ncr5380: Cleanup bogus {request,release}_region() calls Hannes Reinecke
2015-12-22  1:17 ` [PATCH v3 20/77] ncr5380: Introduce unbound workqueue Finn Thain
2015-12-22  7:10   ` Hannes Reinecke
2015-12-22 12:44     ` Finn Thain
2015-12-22 14:48       ` Hannes Reinecke
2015-12-22  1:17 ` [PATCH v3 21/77] ncr5380: Sleep when polling, if possible Finn Thain
2015-12-22  7:12   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 22/77] ncr5380: Eliminate selecting state Finn Thain
2015-12-22  7:14   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 23/77] ncr5380: Always retry arbitration and selection Finn Thain
2015-12-22  7:14   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 24/77] ncr5380: Implement NCR5380_dma_xfer_len and remove LIMIT_TRANSFERSIZE macro Finn Thain
2015-12-22  7:17   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 25/77] ncr5380: Rework disconnect versus poll logic Finn Thain
2015-12-22  7:21   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 26/77] ncr5380: Fix NCR5380_transfer_pio() result Finn Thain
2015-12-22  7:22   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 27/77] ncr5380: Add missing lock in eh_abort_handler Finn Thain
2015-12-22  7:23   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 28/77] ncr5380: Drop DEF_SCSI_QCMD macro Finn Thain
2015-12-22  7:24   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 29/77] ncr5380: Remove references to linked commands Finn Thain
2015-12-22  7:25   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 30/77] ncr5380: Add missing break after case MESSAGE_REJECT Finn Thain
2015-12-22  7:26   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 31/77] ncr5380: Fix !REQ timeout in do_abort() Finn Thain
2015-12-22  7:26   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 32/77] ncr5380: Fix bus phase " Finn Thain
2015-12-22  7:27   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 33/77] atari_NCR5380: Set do_abort() timeouts Finn Thain
2015-12-22  7:29   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 34/77] atari_NCR5380: Use arbitration timeout Finn Thain
2015-12-22  7:30   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 35/77] ncr5380: Dont wait for BUS FREE after disconnect Finn Thain
2015-12-22  7:31   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 36/77] ncr5380: Use work_struct instead of delayed_work Finn Thain
2015-12-22  7:32   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 37/77] ncr5380: Standardize work queueing algorithm Finn Thain
2015-12-22  7:33   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 38/77] ncr5380: Remove UNSAFE macro Finn Thain
2015-12-22  7:34   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 39/77] ncr5380: Standardize interrupt handling Finn Thain
2015-12-22  7:36   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 40/77] ncr5380: Introduce NCR5380_poll_politely2 Finn Thain
2015-12-22  7:37   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 41/77] ncr5380: Replace redundant flags with FLAG_NO_DMA_FIXUP Finn Thain
2015-12-22  7:39   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 42/77] ncr5380: Replace READ_OVERRUNS macro with FLAG_NO_DMA_FIXUPS Finn Thain
2015-12-22  7:39   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 43/77] ncr5380: Standardize reselection handling Finn Thain
2015-12-22  7:41   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 44/77] ncr5380: Fix off-by-one bug in extended_msg[] bounds check Finn Thain
2015-12-22  7:41   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 45/77] ncr5380: Cleanup #include directives Finn Thain
2015-12-22  7:42   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 46/77] ncr5380: Fix NDEBUG_NO_DATAOUT flag Finn Thain
2015-12-22  7:42   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 47/77] ncr5380: Fix and cleanup scsi_host_template initializers Finn Thain
2015-12-22  7:43   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 48/77] atari_NCR5380: Fix queue_size limit Finn Thain
2015-12-22  7:44   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 49/77] ncr5380: Remove redundant ICR_ARBITRATION_LOST test and eliminate FLAG_DTC3181E Finn Thain
2015-12-22  7:45   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 50/77] ncr5380: Change instance->host_lock to hostdata->lock Finn Thain
2015-12-22  7:46   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 51/77] ncr5380: Remove command list debug code Finn Thain
2015-12-22  7:47   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 52/77] ncr5380: Remove H_NO macro and introduce dsprintk Finn Thain
2015-12-22  7:48   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 53/77] ncr5380: Use shost_priv helper Finn Thain
2015-12-22  7:48   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 54/77] ncr5380: Use dsprintk() for queue debugging Finn Thain
2015-12-22  7:50   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 55/77] ncr5380: Remove LIST and REMOVE macros Finn Thain
2015-12-22  7:50   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 56/77] ncr5380: Remove redundant volatile qualifiers Finn Thain
2015-12-22  7:51   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 57/77] ncr5380: Use standard list data structure Finn Thain
2015-12-22  7:55   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 58/77] ncr5380: Refactor command completion Finn Thain
2015-12-22  7:56   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 59/77] ncr5380: Fix autosense bugs Finn Thain
2015-12-22  7:57   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 60/77] ncr5380: Implement new eh_abort_handler Finn Thain
2015-12-22  7:59   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 61/77] ncr5380: Fix EH during arbitration and selection Finn Thain
2015-12-22  8:00   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 62/77] ncr5380: Implement new eh_bus_reset_handler Finn Thain
2015-12-22  8:01   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 63/77] atari_NCR5380: Remove HOSTNO macro from printk() and seq_printf() calls Finn Thain
2015-12-22  8:02   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 64/77] atari_NCR5380: Eliminate HOSTNO macro Finn Thain
2015-12-22  8:02   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 65/77] atari_scsi, sun3_scsi: Remove global Scsi_Host pointer Finn Thain
2015-12-22  8:03   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 66/77] ncr5380: Fix soft lockups Finn Thain
2015-12-22  8:03   ` Hannes Reinecke
2015-12-22 11:39   ` One Thousand Gnomes
2015-12-22 13:47     ` Finn Thain
2015-12-23  0:42       ` Michael Schmitz
2015-12-22  1:18 ` [PATCH v3 67/77] ncr5380: Cleanup comments Finn Thain
2015-12-22  8:04   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 68/77] ncr5380: Fix whitespace issues using regexp Finn Thain
2015-12-22  8:04   ` Hannes Reinecke
2015-12-22 14:46   ` Joe Perches
2015-12-23  0:56     ` Finn Thain
2015-12-23  1:13       ` Joe Perches
2015-12-23  2:03         ` Finn Thain
2015-12-23  2:18           ` Joe Perches
2015-12-23  4:14             ` Finn Thain
2015-12-23  1:22       ` James Bottomley
2015-12-23  2:31         ` Finn Thain
2015-12-22  1:18 ` [PATCH v3 69/77] ncr5380: Merge changes from atari_NCR5380.c Finn Thain
2015-12-22  8:05   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 70/77] atari_NCR5380: Merge changes from NCR5380.c Finn Thain
2015-12-22  8:05   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 71/77] ncr5380: Cleanup whitespace and parentheses Finn Thain
2015-12-22  8:06   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 72/77] ncr5380: Fix pseudo DMA transfers on 53C400 Finn Thain
2015-12-22  8:06   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 73/77] ncr5380: Use runtime register mapping Finn Thain
2015-12-22  8:07   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 74/77] ncr5380: Enable PDMA for NCR53C400A Finn Thain
2015-12-22  8:07   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 75/77] ncr5380: Enable PDMA for DTC chips Finn Thain
2015-12-22  8:08   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 76/77] ncr5380: Fix wait for 53C80 registers registers after PDMA Finn Thain
2015-12-22  8:08   ` Hannes Reinecke
2015-12-22  1:18 ` [PATCH v3 77/77] ncr5380: Add support for HP C2502 Finn Thain
2015-12-22  8:09   ` Hannes Reinecke
2015-12-22 20:14 ` [PATCH v3 00/77] More fixes, cleanup and modernization for NCR5380 drivers Ondrej Zary
2016-01-01  1:28 ` Michael Schmitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151222011743.205522414@telegraphics.com.au \
    --to=fthain@telegraphics.com.au \
    --cc=JBottomley@odin.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=martin.petersen@oracle.com \
    --cc=schmitzmic@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).