From: Christoph Hellwig <hch@lst.de>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: Bart Van Assche <bart.vanassche@sandisk.com>,
Christoph Hellwig <hch@lst.de>,
"Nicholas A. Bellinger" <nab@daterainc.com>,
target-devel <target-devel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
Sagi Grimberg <sagig@mellanox.com>,
Hannes Reinecke <hare@suse.de>, Andy Grover <agrover@redhat.com>,
Vasu Dev <vasu.dev@linux.intel.com>, Vu Pham <vu@mellanox.com>,
Himanshu Madhani <himanshu.madhani@qlogic.com>,
Giridhar Malavali <giridhar.malavali@qlogic.com>
Subject: Re: [PATCH 1/4] target: Obtain se_node_acl->acl_kref during get_initiator_node_acl
Date: Fri, 8 Jan 2016 10:08:46 +0100 [thread overview]
Message-ID: <20160108090846.GA746@lst.de> (raw)
In-Reply-To: <1452242859.27508.12.camel@haakon3.risingtidesystems.com>
On Fri, Jan 08, 2016 at 12:47:39AM -0800, Nicholas A. Bellinger wrote:
> Actually no, they do not. That's the way that everything outside of
> tcm_fc + ib_srpt driver code has already worked for a long time.
Another reason to introduce a helper to enforce that ordering!
Everything but iscsi and qla2xxx is absolutely trivial to convert.
qla2xxx needs some work, but I think it's actually wrong currently
as it sets the s_id and loop_id unconditionally even if we're
reusing an existing node ACL. iscsi is black magic as usual, so I'm
a little lost..
next prev parent reply other threads:[~2016-01-08 9:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 7:15 [PATCH 0/4] target: Close se_node_acl lookup race Nicholas A. Bellinger
2016-01-08 7:15 ` [PATCH 1/4] target: Obtain se_node_acl->acl_kref during get_initiator_node_acl Nicholas A. Bellinger
2016-01-08 8:14 ` Christoph Hellwig
2016-01-08 8:31 ` Bart Van Assche
2016-01-08 8:35 ` Christoph Hellwig
2016-01-08 8:47 ` Nicholas A. Bellinger
2016-01-08 9:08 ` Christoph Hellwig [this message]
2016-01-08 9:37 ` Christoph Hellwig
2016-01-08 7:15 ` [PATCH 2/4] target: Remove useless set_initiator_node_queue_depth acl lookup Nicholas A. Bellinger
2016-01-08 8:17 ` Christoph Hellwig
2016-01-08 7:15 ` [PATCH 3/4] tcm_fc: Convert acl lookup to modern get_initiator_node_acl usage Nicholas A. Bellinger
2016-01-08 8:21 ` Christoph Hellwig
2016-01-08 9:05 ` Christoph Hellwig
2016-01-08 7:15 ` [PATCH 4/4] ib_srpt: " Nicholas A. Bellinger
2016-01-08 8:52 ` Bart Van Assche
2016-01-08 9:17 ` Nicholas A. Bellinger
2016-01-08 9:35 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160108090846.GA746@lst.de \
--to=hch@lst.de \
--cc=agrover@redhat.com \
--cc=bart.vanassche@sandisk.com \
--cc=giridhar.malavali@qlogic.com \
--cc=hare@suse.de \
--cc=himanshu.madhani@qlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@daterainc.com \
--cc=nab@linux-iscsi.org \
--cc=sagig@mellanox.com \
--cc=target-devel@vger.kernel.org \
--cc=vasu.dev@linux.intel.com \
--cc=vu@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).