From: Johannes Thumshirn <jthumshirn@suse.de>
To: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
gregkh@linuxfoundation.org, jasowang@redhat.com,
ohering@suse.com, jbottomley@parallels.com,
linux-kernel@vger.kernel.org, hch@infradead.org, hare@suse.de,
apw@canonical.com, devel@linuxdriverproject.org
Subject: Re: [PATCH V2 1/2] scsi: storvsc: Install the storvsc specific timeout handler for FC devices
Date: Thu, 28 Jan 2016 09:28:40 +0100 [thread overview]
Message-ID: <20160128082840.GD27565@c203.arch.suse.de> (raw)
In-Reply-To: <1453947765-28764-1-git-send-email-kys@microsoft.com>
On Wed, Jan 27, 2016 at 06:22:44PM -0800, K. Y. Srinivasan wrote:
> The default timeout routine used for FC transport is not
> suitable for FC devices managed by storvsc since FC devices
> managed by storvsc driver do not have an rport associated
> with them. Use the time out handler used for SCSI devices
> for FC devices as well.
>
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> Reviewed-by: Alex Ng <alexng@microsoft.com>
> Tested-by: Vivek Yadav <vyadav@microsoft.com>
> ---
> drivers/scsi/storvsc_drv.c | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> index 41c115c..622f64a 100644
> --- a/drivers/scsi/storvsc_drv.c
> +++ b/drivers/scsi/storvsc_drv.c
> @@ -42,6 +42,7 @@
> #include <scsi/scsi_devinfo.h>
> #include <scsi/scsi_dbg.h>
> #include <scsi/scsi_transport_fc.h>
> +#include <scsi/scsi_transport.h>
>
> /*
> * All wire protocol details (storage protocol between the guest and the host)
> @@ -1770,6 +1771,11 @@ static int __init storvsc_drv_init(void)
> fc_transport_template = fc_attach_transport(&fc_transport_functions);
> if (!fc_transport_template)
> return -ENODEV;
> +
> + /*
> + * Install Hyper-V specific timeout handler.
> + */
> + fc_transport_template->eh_timed_out = storvsc_eh_timed_out;
> #endif
>
> ret = vmbus_driver_register(&storvsc_drv);
> --
> 1.7.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
prev parent reply other threads:[~2016-01-28 8:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 2:22 [PATCH V2 0/2] scsi: storvsc: Miscellaneous fixes K. Y. Srinivasan
2016-01-28 2:22 ` [PATCH V2 1/2] scsi: storvsc: Install the storvsc specific timeout handler for FC devices K. Y. Srinivasan
2016-01-28 2:22 ` [PATCH V2 2/2] scsi: storvsc: Use the specified target ID in device lookup K. Y. Srinivasan
2016-01-28 8:29 ` Johannes Thumshirn
2016-01-28 8:28 ` Johannes Thumshirn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160128082840.GD27565@c203.arch.suse.de \
--to=jthumshirn@suse.de \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=jasowang@redhat.com \
--cc=jbottomley@parallels.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ohering@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).