From: Mike Snitzer <snitzer@redhat.com>
To: Hannes Reinecke <hare@suse.de>
Cc: Junichi Nomura <j-nomura@ce.jp.nec.com>,
device-mapper development <dm-devel@redhat.com>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: dm-multipath test scripts
Date: Sat, 20 Feb 2016 11:34:49 -0500 [thread overview]
Message-ID: <20160220163449.GA26384@redhat.com> (raw)
In-Reply-To: <56C834F8.8050604@suse.de>
On Sat, Feb 20 2016 at 4:42am -0500,
Hannes Reinecke <hare@suse.de> wrote:
> On 02/20/2016 07:12 AM, Mike Snitzer wrote:
> >On Fri, Feb 19 2016 at 2:42pm -0500,
> >Mike Snitzer <snitzer@redhat.com> wrote:
> >
> >>On Fri, Feb 19 2016 at 3:37am -0500,
> >>Junichi Nomura <j-nomura@ce.jp.nec.com> wrote:
> >>
> >>>On 02/19/16 09:33, Nomura Junichi wrote:
> >>>>On 02/19/16 02:17, Mike Snitzer wrote:
> >>>>>What is the last kernel version that your scripts have worked on?
> >>>>
> >>>>v4.4 worked fine. I'll check with v4.5-rc4 when I get a machine.
> >>>
> >>>v4.5-rc4 works fine, too.
> >>
> >>Have you been running with blk-mq?
> >>Either by setting CONFIG_DM_MQ_DEFAULT or:
> >>echo Y > /sys/module/dm_mod/parameters/use_blk_mq
> >>
> >>I'm seeing test_02_sdev_delete fail with blk-mq enabled.
> >
> >I only see failure if I stack dm-mq ontop of old non-mq scsi devices with:
> >
> >echo N > /sys/module/scsi_mod/parameters/use_blk_mq
> >echo Y > /sys/module/dm_mod/parameters/use_blk_mq
> >
> >If I use scsi-mq for the underlying devices all works fine (been testing
> >the latest dm-4.6 branch though, I'll go back and try stock 4.5-rc4 just
> >to double check).
> >
> >But this makes me think the novelty of having dm-mq support stacking on
> >non-blk-mq devices was misplaced. It is a senseless config. I'll
> >probably remove support for such stacking soon (next week).
>
> Hmm. I must admit I really, really don't like these 'once-and-for-all'
> parameter.
>
> ATM the only SCSI driver to support SCSI-mq properly are lpfc,
> virtio, and fnic. None of the other driver have been modified, and I
> suspect the performance might be less than stellar.
>
> So there will be configurations where one might want to run scsi-mq
> alongside non-mq HBAs.
dm-mq already disallows such a mix though. From dm_table_set_type():
if (use_blk_mq) {
/* verify _all_ devices in the table are blk-mq devices */
list_for_each_entry(dd, devices, list)
if (!bdev_get_queue(dd->dm_dev->bdev)->mq_ops) {
DMERR("table load rejected: not all devices"
" are blk-mq request-stackable");
return -EINVAL;
}
t->type = DM_TYPE_MQ_REQUEST_BASED;
}
But I was talking about removing support for dm-mq stacked on _all_ old
.request_fn devices.
> I would really love to see to make that more granular so that these
> configurations can run efficiently.
> I know Christoph is violently against it, but I don't really see any
> solution presenting itself at the moment.
I'm with Christoph on this. Supporting such elaborate mixing is too
fragile. Time would be much better spent converting drivers to properly
support scsi-mq and/or fixing scsi-mq to perform better.
> Maybe a good topic for LSF ...
Unlikely.. but don't let me stop you! ;)
next prev parent reply other threads:[~2016-02-20 16:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-07 5:39 dm-multipath test scripts Junichi Nomura
2015-10-07 7:31 ` Johannes Thumshirn
2015-10-08 23:10 ` Junichi Nomura
2015-11-13 10:55 ` Johannes Thumshirn
2015-11-14 16:26 ` Mike Snitzer
2016-02-18 17:17 ` Mike Snitzer
2016-02-19 0:33 ` Junichi Nomura
2016-02-19 8:37 ` Junichi Nomura
2016-02-19 19:42 ` Mike Snitzer
2016-02-20 6:12 ` Mike Snitzer
2016-02-20 9:42 ` Hannes Reinecke
2016-02-20 15:13 ` [dm-devel] " Bart Van Assche
2016-02-20 16:34 ` Mike Snitzer [this message]
2016-02-22 9:51 ` Junichi Nomura
2016-02-22 15:09 ` why is blk-mq requeue foricbly kicking stopped queues? [was: Re: dm-multipath test scripts] Mike Snitzer
2016-02-23 1:34 ` Junichi Nomura
2016-02-23 3:43 ` Mike Snitzer
2016-02-24 19:37 ` dm-multipath test scripts Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160220163449.GA26384@redhat.com \
--to=snitzer@redhat.com \
--cc=dm-devel@redhat.com \
--cc=hare@suse.de \
--cc=j-nomura@ce.jp.nec.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).