From: Neil Horman <nhorman@tuxdriver.com>
To: Usha Ketineni <usha.k.ketineni@intel.com>
Cc: linux-scsi@vger.kernel.org, fcoe-devel@open-fcoe.org
Subject: Re: [Open-FCoE] [PATCH] fcoe: fix reset of fip selection time.
Date: Mon, 29 Feb 2016 15:16:27 -0500 [thread overview]
Message-ID: <20160229201627.GA11220@hmsreliant.think-freely.org> (raw)
In-Reply-To: <20160229113652.2680.73280.stgit@ukketine.jf.intel.com>
On Mon, Feb 29, 2016 at 03:36:52AM -0800, Usha Ketineni wrote:
> Do not reset fip selection time for every advertisement
> in fcoe_ctlr_recv_adv() but set it only once for the first
> validated FCF. Otherwise FCF selection won't happen when the
> advertisements consistently arrive with sub FCOE_CTLR_START_DELAY
> periodicity.
>
> Tested-by: Narendra K <narendra_k@dell.com>
> Acked-by: Neil Horman <nhorman@tuxdriver.com>
> Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
> Acked-by: Vasu Dev <vasu.dev@intel.com>
> Signed-off-by: Usha Ketineni <usha.k.ketineni@intel.com>
> ---
> drivers/scsi/fcoe/fcoe_ctlr.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/fcoe/fcoe_ctlr.c b/drivers/scsi/fcoe/fcoe_ctlr.c
> index d68d572..0c85ef6 100644
> --- a/drivers/scsi/fcoe/fcoe_ctlr.c
> +++ b/drivers/scsi/fcoe/fcoe_ctlr.c
> @@ -1079,7 +1079,8 @@ static void fcoe_ctlr_recv_adv(struct fcoe_ctlr *fip, struct sk_buff *skb)
> * If this is the first validated FCF, note the time and
> * set a timer to trigger selection.
> */
> - if (mtu_valid && !fip->sel_fcf && fcoe_ctlr_fcf_usable(fcf)) {
> + if (mtu_valid && !fip->sel_fcf && !fip->sel_time &&
> + fcoe_ctlr_fcf_usable(fcf)) {
> fip->sel_time = jiffies +
> msecs_to_jiffies(FCOE_CTLR_START_DELAY);
> if (!timer_pending(&fip->timer) ||
>
> _______________________________________________
> fcoe-devel mailing list
> fcoe-devel@open-fcoe.org
> http://lists.open-fcoe.org/mailman/listinfo/fcoe-devel
>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
next prev parent reply other threads:[~2016-02-29 20:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 11:36 [PATCH] fcoe: fix reset of fip selection time Usha Ketineni
2016-02-29 20:16 ` Neil Horman [this message]
2016-03-01 2:02 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160229201627.GA11220@hmsreliant.think-freely.org \
--to=nhorman@tuxdriver.com \
--cc=fcoe-devel@open-fcoe.org \
--cc=linux-scsi@vger.kernel.org \
--cc=usha.k.ketineni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox