From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>, Ewan Milne <emilne@redhat.com>,
Bart van Assche <bart.vanassche@sandisk.com>,
James Bottomley <james.bottomley@hansenpartnership.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/6] scsi: Add 'access_state' and 'preferred_path' attribute
Date: Tue, 1 Mar 2016 14:06:04 +0100 [thread overview]
Message-ID: <20160301130604.GC7616@lst.de> (raw)
In-Reply-To: <1456808143-88932-2-git-send-email-hare@suse.de>
On Tue, Mar 01, 2016 at 05:55:38AM +0100, Hannes Reinecke wrote:
> Add an 'access_state' field to struct scsi_device
> and display them in sysfs as 'access_state' and
> 'preferred_path' attribute.
>
> Signed-off-by: Hannes Reinecke <hare@suse.de>
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
(I don't care about the *printf holy war for constant strings. In all
truth sysfs should switch to the seq_file API ASAP and end that misery..)
next prev parent reply other threads:[~2016-03-01 13:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 4:55 [PATCH 0/6] SCSI 'access_state' attribute Hannes Reinecke
2016-03-01 4:55 ` [PATCH 1/6] scsi: Add 'access_state' and 'preferred_path' attribute Hannes Reinecke
2016-03-01 7:08 ` Seymour, Shane M
2016-03-01 8:01 ` Hannes Reinecke
2016-03-01 13:06 ` Christoph Hellwig [this message]
2016-03-01 20:54 ` Bart Van Assche
2016-03-01 4:55 ` [PATCH 2/6] scsi_dh_alua: use common definitions for ALUA state Hannes Reinecke
2016-03-01 18:47 ` Bart Van Assche
2016-03-01 4:55 ` [PATCH 3/6] scsi_dh_alua: update 'access_state' field Hannes Reinecke
2016-03-01 4:55 ` [PATCH 4/6] scsi_dh_rdac: " Hannes Reinecke
2016-03-01 13:08 ` Christoph Hellwig
2016-03-01 4:55 ` [PATCH 5/6] scsi_dh_emc: " Hannes Reinecke
2016-03-01 13:08 ` Christoph Hellwig
2016-03-01 4:55 ` [PATCH 6/6] scsi_sysfs: call 'device_add' after attaching device handler Hannes Reinecke
2016-03-01 13:07 ` Christoph Hellwig
2016-03-01 18:51 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160301130604.GC7616@lst.de \
--to=hch@lst.de \
--cc=bart.vanassche@sandisk.com \
--cc=emilne@redhat.com \
--cc=hare@suse.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).