From: Christoph Hellwig <hch@infradead.org>
To: Sagi Grimberg <sagig@dev.mellanox.co.il>
Cc: Varun Prakash <varun@chelsio.com>,
target-devel@vger.kernel.org, linux-scsi@vger.kernel.org,
nab@linux-iscsi.org, roland@kernel.org,
swise@opengridcomputing.com, indranil@chelsio.com,
kxie@chelsio.com, hariprasad@chelsio.com
Subject: Re: [RFC 18/34] iscsi-target: call complete on conn_logout_comp
Date: Tue, 1 Mar 2016 06:52:14 -0800 [thread overview]
Message-ID: <20160301145214.GE9738@infradead.org> (raw)
In-Reply-To: <56C205C7.9000503@dev.mellanox.co.il>
On Mon, Feb 15, 2016 at 07:07:19PM +0200, Sagi Grimberg wrote:
> >+ if ((conn->conn_transport->transport_type == ISCSI_TCP) ||
> >+ (conn->conn_transport->transport_type == ISCSI_TCP_CXGB4))
> > complete(&conn->conn_logout_comp);
>
> IMO, this is an indication that this condition is a bandage in the first
> place...
Agreed. Nevermind the fact that a spurious complete() is perfectly
harmless..
> While this is unrelated to the patch set, we should look into the iscsi
> termination sequences more closely and look if we can dispatch some
> logic to the drivers in places they defer. It will make the code much
> less complicated.
Yes, all I've seen in this series so far suggest that the integration
is a complete mess. I think this really needs to go back to the drawing
board.
next prev parent reply other threads:[~2016-03-01 14:52 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-14 17:30 [RFC 00/34] Chelsio iSCSI target offload driver Varun Prakash
2016-02-14 17:32 ` [RFC 01/34] cxgb4: add new ULD type CXGB4_ULD_ISCSIT Varun Prakash
2016-02-14 17:32 ` [RFC 02/34] cxgb4: allocate resources for CXGB4_ULD_ISCSIT Varun Prakash
2016-02-14 17:32 ` [RFC 03/34] cxgb4: large receive offload support Varun Prakash
2016-02-14 17:34 ` [RFC 04/34] cxgb4, iw_cxgb4: move definitions to common header file Varun Prakash
2016-02-14 17:34 ` [RFC 05/34] cxgb4, iw_cxgb4, cxgb4i: remove duplicate definitions Varun Prakash
2016-02-14 17:37 ` [RFC 06/34] cxgb4, cxgb4i: move struct cpl_rx_data_ddp definition Varun Prakash
2016-02-14 17:37 ` [RFC 07/34] cxgb4: add definitions for iSCSI target ULD Varun Prakash
2016-02-14 17:37 ` [RFC 08/34] cxgb4: update struct cxgb4_lld_info definition Varun Prakash
2016-02-14 17:37 ` [RFC 09/34] cxgb4: move VLAN_NONE macro definition Varun Prakash
2016-02-14 17:38 ` [RFC 10/34] cxgb4, iw_cxgb4: move delayed ack macro definitions Varun Prakash
2016-02-14 17:39 ` [RFC 11/34] cxgb4: add iSCSI DDP page pod manager Varun Prakash
2016-02-14 17:39 ` [RFC 12/34] cxgb4: update Kconfig and Makefile Varun Prakash
2016-03-01 14:47 ` Christoph Hellwig
2016-03-02 10:56 ` Varun Prakash
2016-02-14 17:42 ` [RFC 13/34] iscsi-target: add new transport type Varun Prakash
2016-03-01 14:48 ` Christoph Hellwig
2016-03-02 11:52 ` Varun Prakash
2016-03-05 21:28 ` Nicholas A. Bellinger
2016-03-07 14:55 ` Varun Prakash
2016-03-07 20:30 ` Nicholas A. Bellinger
2016-02-14 17:42 ` [RFC 14/34] iscsi-target: export symbols Varun Prakash
2016-03-01 14:49 ` Christoph Hellwig
2016-03-02 12:00 ` Varun Prakash
2016-03-05 21:54 ` Nicholas A. Bellinger
2016-03-07 23:22 ` Nicholas A. Bellinger
2016-03-12 6:28 ` Nicholas A. Bellinger
2016-03-13 12:13 ` Varun Prakash
2016-04-08 7:16 ` Nicholas A. Bellinger
2016-04-09 12:09 ` Varun Prakash
2016-04-10 8:56 ` Sagi Grimberg
2016-02-14 17:42 ` [RFC 15/34] iscsi-target: export symbols from iscsi_target.c Varun Prakash
2016-03-01 14:49 ` Christoph Hellwig
2016-03-02 12:07 ` Varun Prakash
2016-02-14 17:42 ` [RFC 16/34] iscsi-target: split iscsit_send_r2t() Varun Prakash
2016-02-14 17:42 ` [RFC 17/34] iscsi-target: split iscsit_send_conn_drop_async_message() Varun Prakash
2016-02-14 17:42 ` [RFC 18/34] iscsi-target: call complete on conn_logout_comp Varun Prakash
2016-02-15 17:07 ` Sagi Grimberg
2016-03-01 14:52 ` Christoph Hellwig [this message]
2016-03-05 21:02 ` Nicholas A. Bellinger
2016-02-14 17:42 ` [RFC 19/34] iscsi-target: clear tx_thread_active Varun Prakash
2016-02-15 17:07 ` Sagi Grimberg
2016-03-01 14:59 ` Christoph Hellwig
2016-02-14 17:42 ` [RFC 20/34] iscsi-target: update struct iscsit_transport definition Varun Prakash
2016-02-15 17:09 ` Sagi Grimberg
2016-02-18 12:36 ` Varun Prakash
2016-02-14 17:42 ` [RFC 21/34] iscsi-target: release transport driver resources Varun Prakash
2016-03-01 14:59 ` Christoph Hellwig
2016-03-02 12:15 ` Varun Prakash
2016-02-14 17:45 ` [RFC 22/34] iscsi-target: call Rx thread function Varun Prakash
2016-02-15 17:16 ` Sagi Grimberg
2016-03-01 15:01 ` Christoph Hellwig
2016-03-05 23:16 ` Nicholas A. Bellinger
2016-02-14 17:45 ` [RFC 23/34] iscsi-target: split iscsi_target_rx_thread() Varun Prakash
2016-03-01 15:02 ` Christoph Hellwig
2016-02-14 17:45 ` [RFC 24/34] iscsi-target: validate conn operational parameters Varun Prakash
2016-03-01 15:03 ` Christoph Hellwig
2016-03-02 12:18 ` Varun Prakash
2016-02-14 17:45 ` [RFC 25/34] iscsi-target: move iscsit_thread_check_cpumask() Varun Prakash
2016-02-14 17:45 ` [RFC 26/34] iscsi-target: fix seq_end_offset calculation Varun Prakash
2016-02-14 17:45 ` [RFC 27/34] cxgbit: add cxgbit.h Varun Prakash
2016-02-14 17:45 ` [RFC 28/34] cxgbit: add cxgbit_lro.h Varun Prakash
2016-02-14 17:45 ` [RFC 29/34] cxgbit: add cxgbit_main.c Varun Prakash
2016-02-14 17:45 ` [RFC 30/34] cxgbit: add cxgbit_cm.c Varun Prakash
2016-02-14 17:45 ` [RFC 31/34] cxgbit: add cxgbit_target.c Varun Prakash
2016-02-14 17:45 ` [RFC 32/34] cxgbit: add cxgbit_ddp.c Varun Prakash
2016-02-14 17:45 ` [RFC 33/34] cxgbit: add Kconfig and Makefile Varun Prakash
2016-02-14 17:45 ` [RFC 34/34] iscsi-target: update " Varun Prakash
2016-02-26 7:29 ` [RFC 00/34] Chelsio iSCSI target offload driver Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160301145214.GE9738@infradead.org \
--to=hch@infradead.org \
--cc=hariprasad@chelsio.com \
--cc=indranil@chelsio.com \
--cc=kxie@chelsio.com \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=roland@kernel.org \
--cc=sagig@dev.mellanox.co.il \
--cc=swise@opengridcomputing.com \
--cc=target-devel@vger.kernel.org \
--cc=varun@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).