From: Mike Snitzer <snitzer@redhat.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Ewan Milne <emilne@redhat.com>,
linux-scsi@vger.kernel.org, Zdenek Kabelac <zkabelac@redhat.com>,
Alasdair G Kergon <agk@redhat.com>,
dm-devel@redhat.com
Subject: Re: scsi-debug regression with 4.5-rc?
Date: Fri, 4 Mar 2016 10:24:09 -0500 [thread overview]
Message-ID: <20160304152409.GA31358@redhat.com> (raw)
In-Reply-To: <yq1powwp7l4.fsf@sermon.lab.mkp.net>
On Wed, Jan 20 2016 at 10:57am -0500,
Martin K. Petersen <martin.petersen@oracle.com> wrote:
> >>>>> "Ewan" == Ewan Milne <emilne@redhat.com> writes:
>
> Ewan> So I have a report from our test people that the optimal_io_size
> Ewan> sysfs value is now different by a factor of 512 from what it used
> Ewan> to be...
>
> Yes, just prepared a patch this morning. I messed up sectors vs. bytes.
Would your fix (commit d0eb20a863ba7dc) address this BZ too?
https://bugzilla.redhat.com/show_bug.cgi?id=1314687
Seems not, I think that BZ may be due to the LBPRZ clause in commit
397737223 ("sd: Make discard granularity match logical block size when LBPRZ=1") ?
should be: q->limits.discard_granularity = 1 * logical_block_size;
Mike
next prev parent reply other threads:[~2016-03-04 15:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 15:17 scsi-debug regression with 4.5-rc? Ewan Milne
2016-01-20 15:57 ` Martin K. Petersen
2016-03-04 15:24 ` Mike Snitzer [this message]
2016-03-05 22:44 ` Martin K. Petersen
2016-03-05 23:10 ` [PATCH] sd: Fix discard granularity when LBPRZ=1 Martin K. Petersen
2016-03-07 15:42 ` Ewan Milne
2016-03-08 2:21 ` Martin K. Petersen
2016-03-08 17:02 ` Bart Van Assche
2016-03-09 1:51 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160304152409.GA31358@redhat.com \
--to=snitzer@redhat.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=emilne@redhat.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=zkabelac@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).