From: Dan Carpenter <dan.carpenter@oracle.com>
To: huangj@brocade.com
Cc: linux-scsi@vger.kernel.org
Subject: re: [SCSI] bfa: Brocade BFA FC SCSI driver
Date: Fri, 11 Mar 2016 11:25:37 +0300 [thread overview]
Message-ID: <20160311082537.GA28779@mwanda> (raw)
Hello Jing Huang,
The patch 7725ccfda597: "[SCSI] bfa: Brocade BFA FC SCSI driver" from
Sep 23, 2009, leads to the following static checker warning:
drivers/scsi/bfa/bfa_fcs_fcpim.c:596 bfa_fcs_itnim_create()
error: potentially using uninitialized 'itnim'.
drivers/scsi/bfa/bfa_fcs_fcpim.c
588 struct bfa_fcs_lport_s *port = rport->port;
589 struct bfa_fcs_itnim_s *itnim;
^^^^^
590 struct bfad_itnim_s *itnim_drv;
591
592 /*
593 * call bfad to allocate the itnim
594 */
595 bfa_fcb_itnim_alloc(port->fcs->bfad, &itnim, &itnim_drv);
^^^^^
This function should probably return negative error codes on failure.
596 if (itnim == NULL) {
^^^^^^^^^^^^^
597 bfa_trc(port->fcs, rport->pwwn);
598 return NULL;
599 }
regards,
dan carpenter
reply other threads:[~2016-03-11 8:25 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160311082537.GA28779@mwanda \
--to=dan.carpenter@oracle.com \
--cc=huangj@brocade.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).