From: Dan Carpenter <dan.carpenter@oracle.com>
To: sagig@mellanox.com
Cc: open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org
Subject: re: libiscsi: Use scsi helper to set information descriptor
Date: Wed, 13 Apr 2016 16:14:25 +0300 [thread overview]
Message-ID: <20160413131425.GA9719@mwanda> (raw)
Hello Sagi Grimberg,
The patch a73c2a2f9123: "libiscsi: Use scsi helper to set information
descriptor" from Jul 15, 2015, leads to the following static checker
warning:
drivers/scsi/libiscsi.c:858 iscsi_scsi_cmd_rsp()
error: XXX uninitialized symbol 'sector'.
drivers/scsi/libiscsi.c
850 ascq = session->tt->check_protection(task, §or);
If "ascq" is 0x1 then there sector might not be initialized. The
documentation is not clear on how that works. Har dee har har. The
oldest jokes are still the best... :P
851 if (ascq) {
852 sc->result = DRIVER_SENSE << 24 |
853 SAM_STAT_CHECK_CONDITION;
854 scsi_build_sense_buffer(1, sc->sense_buffer,
855 ILLEGAL_REQUEST, 0x10, ascq);
856 scsi_set_sense_information(sc->sense_buffer,
857 SCSI_SENSE_BUFFERSIZE,
858 sector);
859 goto out;
860 }
regards,
dan carpenter
next reply other threads:[~2016-04-13 13:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 13:14 Dan Carpenter [this message]
2016-04-13 14:53 ` libiscsi: Use scsi helper to set information descriptor Sagi Grimberg
2016-04-13 16:30 ` Dan Carpenter
2016-05-04 11:45 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160413131425.GA9719@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=open-iscsi@googlegroups.com \
--cc=sagig@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).