* [patch] [SCSI] eata_pio: missing break statement
@ 2016-05-04 6:13 Dan Carpenter
2016-05-11 2:01 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2016-05-04 6:13 UTC (permalink / raw)
To: James E.J. Bottomley
Cc: Martin K. Petersen, linux-scsi, linux-kernel, kernel-janitors
This missing break statement bug predates git. It's a very minor thing,
it means that we print a '?' instead of a 'z' in dmesg.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/scsi/eata_pio.c b/drivers/scsi/eata_pio.c
index ca8003f..4299fa4 100644
--- a/drivers/scsi/eata_pio.c
+++ b/drivers/scsi/eata_pio.c
@@ -729,6 +729,7 @@ static int register_pio_HBA(long base, struct get_conf *gc, struct pci_dev *pdev
break;
case 0x24:
SD(sh)->EATA_revision = 'z';
+ break;
default:
SD(sh)->EATA_revision = '?';
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] [SCSI] eata_pio: missing break statement
2016-05-04 6:13 [patch] [SCSI] eata_pio: missing break statement Dan Carpenter
@ 2016-05-11 2:01 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2016-05-11 2:01 UTC (permalink / raw)
To: Dan Carpenter
Cc: James E.J. Bottomley, Martin K. Petersen, linux-scsi,
linux-kernel, kernel-janitors
>>>>> "Dan" == Dan Carpenter <dan.carpenter@oracle.com> writes:
Dan> This missing break statement bug predates git. It's a very minor
Dan> thing, it means that we print a '?' instead of a 'z' in dmesg.
Applied to 4.7/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-11 2:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-04 6:13 [patch] [SCSI] eata_pio: missing break statement Dan Carpenter
2016-05-11 2:01 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).