From: Dan Carpenter <dan.carpenter@oracle.com>
To: Finn Thain <fthain@telegraphics.com.au>
Cc: Petros Koutoupis <petros@petroskoutoupis.com>,
kashyap.desai@avagotech.com, sumit.saxena@avagotech.com,
uday.lingala@avagotech.com, megaraidlinux.pdl@avagotech.com,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] megaraid: add scsi_cmnd NULL check before use
Date: Mon, 9 May 2016 11:05:51 +0300 [thread overview]
Message-ID: <20160509080551.GH29510@mwanda> (raw)
In-Reply-To: <alpine.LNX.2.00.1605081235490.19865@nippy.intranet>
Smatch doesn't quite catch it because we check "cmd_fusion->scmd" for
NULL then assign "scmd_local = cmd_fusion->scmd;" and dereference
scmd_local unconditionally...
It does catch part of the bug if you have cross function analysis:
drivers/scsi/megaraid/megaraid_sas_fusion.c:2318 complete_cmd_fusion()
error: we previously assumed 'cmd_fusion->scmd' could be null (see line 2281)
But that code was from 2010 so I never reported it to the original
author or the list.
regards,
dan carpenter
next prev parent reply other threads:[~2016-05-09 8:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-08 0:40 [PATCH] megaraid: add scsi_cmnd NULL check before use Petros Koutoupis
2016-05-08 3:32 ` Finn Thain
2016-05-08 12:08 ` Petros Koutoupis
2016-05-08 12:22 ` Finn Thain
2016-05-08 16:34 ` Petros Koutoupis
2016-05-09 1:35 ` Julian Calaby
2016-05-09 2:59 ` Petros Koutoupis
2016-05-09 8:05 ` Dan Carpenter [this message]
2016-05-09 9:43 ` Dan Carpenter
2016-05-09 9:48 ` Sumit Saxena
2016-05-09 19:29 ` Dan Carpenter
2016-05-09 21:28 ` Petros Koutoupis
2016-05-11 9:41 ` Sumit Saxena
2016-05-12 1:49 ` Petros Koutoupis
2016-05-12 6:35 ` Dan Carpenter
2016-05-12 12:35 ` Sumit Saxena
2016-05-13 7:43 ` Finn Thain
2016-05-13 7:43 ` Sumit Saxena
2016-05-13 9:25 ` Finn Thain
2016-05-13 23:34 ` Petros Koutoupis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160509080551.GH29510@mwanda \
--to=dan.carpenter@oracle.com \
--cc=fthain@telegraphics.com.au \
--cc=kashyap.desai@avagotech.com \
--cc=linux-scsi@vger.kernel.org \
--cc=megaraidlinux.pdl@avagotech.com \
--cc=petros@petroskoutoupis.com \
--cc=sumit.saxena@avagotech.com \
--cc=uday.lingala@avagotech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).