From: Christoph Hellwig <hch@lst.de>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: target-devel <target-devel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
linux-nvme <linux-nvme@lists.infradead.org>,
Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@lst.de>,
Keith Busch <keith.busch@intel.com>,
Jay Freyensee <james.p.freyensee@intel.com>,
Martin Petersen <martin.petersen@oracle.com>,
Sagi Grimberg <sagi@grimberg.me>, Hannes Reinecke <hare@suse.de>,
Mike Christie <michaelc@cs.wisc.edu>,
Dave B Minturn <dave.b.minturn@intel.com>
Subject: Re: [RFC-v2 00/11] nvmet: Add support for multi-tenant configfs
Date: Tue, 14 Jun 2016 16:52:43 +0200 [thread overview]
Message-ID: <20160614145243.GA29949@lst.de> (raw)
In-Reply-To: <1465878946-26556-1-git-send-email-nab@linux-iscsi.org>
On Tue, Jun 14, 2016 at 04:35:35AM +0000, Nicholas A. Bellinger wrote:
> Comments..?
Still no good reason for doing anything like this.
On a conceptual level:
The NVMe target is front end implementing a simple protocol to export
block devices to a remove host. The SCSI target is larger front end to
expose a more complex protocol to remote hosts. None of them should
actually implement any real protocol independent behavior, and except for
persistent reservations in the SCSI neither of them does.
On a practical level it means we drag in over 25.000 lines of code
as a dependency, without actually dropping any code in the nvmet module,
and vastly more complicated object hierarchies that don't make any
sense for the tight-knit NVMe standard. We'd also get dragged into
into the nightmare of diverging an incompatible user space tooling,
and we'd lose all the test coverage we've built up. We'd also have
to deal with tons of tunables that neither fit the protocol we
implement nor the philosophy of the project.
prev parent reply other threads:[~2016-06-14 14:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 4:35 [RFC-v2 00/11] nvmet: Add support for multi-tenant configfs Nicholas A. Bellinger
2016-06-14 4:35 ` [RFC-v2 01/11] nvme-fabrics: Export nvmf_host_add + generate hostnqn if necessary Nicholas A. Bellinger
2016-06-14 4:35 ` [RFC-v2 02/11] nvmet: Add nvmet_fabric_ops get/put transport helpers Nicholas A. Bellinger
2016-06-14 4:35 ` [RFC-v2 03/11] nvmet: Add support for configfs-ng multi-tenant logic Nicholas A. Bellinger
2016-06-14 4:35 ` [RFC-v2 04/11] nvmet: Hookup nvmet_ns->dev to nvmet_ns_enable Nicholas A. Bellinger
2016-06-14 4:35 ` [RFC-v2 05/11] nvmet/loop: Add support for controller-per-port model + nvmet_port_binding Nicholas A. Bellinger
2016-06-14 4:35 ` [RFC-v2 06/11] nvmet/rdma: Convert to struct nvmet_port_binding Nicholas A. Bellinger
2016-06-14 4:35 ` [RFC-v2 07/11] nvmet/io-cmd: Hookup sbc_ops->execute_rw backend ops Nicholas A. Bellinger
2016-06-14 4:35 ` [RFC-v2 08/11] nvmet/io-cmd: Hookup sbc_ops->execute_sync_cache " Nicholas A. Bellinger
2016-06-14 4:35 ` [RFC-v2 09/11] nvmet/io-cmd: Hookup sbc_ops->execute_unmap " Nicholas A. Bellinger
2016-06-14 4:35 ` [RFC-v2 10/11] nvmet/admin-cmd: Hookup T10-PI to ID_NS.ms + ID_NS.dps feature bits Nicholas A. Bellinger
2016-06-14 4:35 ` [RFC-v2 11/11] nvmet/loop: Add support for bio integrity handling Nicholas A. Bellinger
2016-06-14 14:52 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160614145243.GA29949@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=dave.b.minturn@intel.com \
--cc=hare@suse.de \
--cc=james.p.freyensee@intel.com \
--cc=keith.busch@intel.com \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michaelc@cs.wisc.edu \
--cc=nab@linux-iscsi.org \
--cc=sagi@grimberg.me \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).