From: Tejun Heo <tj@kernel.org>
To: Tom Yan <tom.ty89@gmail.com>
Cc: Hannes Reinecke <hare@suse.de>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Arnd Bergmann <arnd@arndb.de>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-next@vger.kernel.org
Subject: Re: [PATCH resend 3/5] libata-scsi: fix overflow in mode page copy
Date: Thu, 21 Jul 2016 17:42:02 -0400 [thread overview]
Message-ID: <20160721214202.GG23759@htj.duckdns.org> (raw)
In-Reply-To: <CAGnHSEkj2kXNUyQa=MxmLsTJT3P9xrQjpjoMLYiz6xKPB896EA@mail.gmail.com>
On Fri, Jul 22, 2016 at 05:39:27AM +0800, Tom Yan wrote:
> Let me know how I should polish the description for this.
The above is because the signed ones are getting sign-extended making
them different from the unsigned ones which don't get padded in the
high bits. Converting to u8 is the right thing to do but nothing here
is getting truncated.
Thanks.
--
tejun
next prev parent reply other threads:[~2016-07-21 21:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 18:41 [PATCH resend 1/5] libata-scsi: minor cleanup in ata_mselect_*() tom.ty89
2016-07-21 18:41 ` [PATCH resend 2/5] libata-scsi: fix read-only bits checking " tom.ty89
2016-07-21 18:41 ` [PATCH resend 3/5] libata-scsi: fix overflow in mode page copy tom.ty89
2016-07-21 18:41 ` [PATCH resend 4/5] libata-scsi: have all checks done before calling ata_mselect_*() tom.ty89
2016-07-21 18:41 ` [PATCH resend 5/5] libata-scsi: fix MODE SELECT translation for Control mode page tom.ty89
2016-07-21 21:26 ` Tejun Heo
2016-07-21 21:50 ` Tom Yan
2016-07-25 18:30 ` Tejun Heo
2016-07-27 21:00 ` Tom Yan
2016-08-10 3:38 ` Tejun Heo
2016-07-21 21:17 ` [PATCH resend 3/5] libata-scsi: fix overflow in mode page copy Tejun Heo
2016-07-21 21:39 ` Tom Yan
2016-07-21 21:42 ` Tejun Heo [this message]
[not found] ` <accc8ca07073cd0292b62903acac956f5f5eff74.1469143747.git.tom.ty89@gmail.com>
[not found] ` <9bbf2b818f9ca1bb48f1eae31a0f3924a4fe0d9a.1469143747.git.tom.ty89@gmail.com>
2016-07-21 23:29 ` [PATCH resend v2 3/5] libata-scsi: use u8 array to store " tom.ty89
2016-07-22 9:59 ` Sergei Shtylyov
2016-07-22 18:22 ` Tom Yan
2016-07-22 18:34 ` [PATCH resend v3 " tom.ty89
2016-08-09 20:13 ` Tejun Heo
2016-07-21 23:35 ` [PATCH resend v2 " tom.ty89
2016-07-21 23:20 ` [PATCH resend 2/5] libata-scsi: fix read-only bits checking in ata_mselect_*() Tom Yan
[not found] ` <accc8ca07073cd0292b62903acac956f5f5eff74.1469143271.git.tom.ty89@gmail.com>
2016-07-21 23:25 ` [PATCH resend v2 " tom.ty89
2016-07-21 23:34 ` tom.ty89
2016-07-21 18:45 ` [PATCH resend 1/5] libata-scsi: minor cleanup " Sergei Shtylyov
2016-07-21 18:51 ` Tom Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160721214202.GG23759@htj.duckdns.org \
--to=tj@kernel.org \
--cc=arnd@arndb.de \
--cc=hare@suse.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=sfr@canb.auug.org.au \
--cc=tom.ty89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).